From 689ee5bcad370e1f901ff0bc40607bafffee5936 Mon Sep 17 00:00:00 2001 From: Eugenie Ahangama Date: Tue, 14 Apr 2026 03:27:21 +0100 Subject: [PATCH 1/6] Fix empty page title --- debugging/book-library/index.html | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..b57fe5cd 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,7 +1,7 @@ - + - + My Book Library Library type="submit" value="Submit" class="btn btn-primary" - onclick="submit();" + onclick="submit()" /> From 4263d10faf00e76234034e42d71c27d2839902f0 Mon Sep 17 00:00:00 2001 From: Eugenie Ahangama Date: Tue, 14 Apr 2026 03:27:37 +0100 Subject: [PATCH 2/6] Fix book rendering, add/delete bugs and read status logic --- debugging/book-library/script.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..9d1adc01 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -30,15 +30,15 @@ const check = document.getElementById("check"); function submit() { if ( title.value == null || - title.value == "" || + author.value == "" || pages.value == null || pages.value == "" ) { alert("Please fill all fields!"); return false; } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); + let book = new Book(title.value, author.value, pages.value, check.checked); + myLibrary.push(book); render(); } } @@ -54,7 +54,7 @@ function render() { let table = document.getElementById("display"); let rowsNumber = table.rows.length; //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } //insert updated row and cells @@ -76,7 +76,7 @@ function render() { changeBut.className = "btn btn-success"; wasReadCell.appendChild(changeBut); let readStatus = ""; - if (myLibrary[i].check == false) { + if (myLibrary[i].check == true) { readStatus = "Yes"; } else { readStatus = "No"; @@ -89,12 +89,12 @@ function render() { }); //add delete button to every row and render again - let delButton = document.createElement("button"); + let delBut = document.createElement("button"); delBut.id = i + 5; deleteCell.appendChild(delBut); delBut.className = "btn btn-warning"; delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { + delBut.addEventListener("click", function () { alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); From 4eca291384941d4038e2118c9d2884b324095742 Mon Sep 17 00:00:00 2001 From: Eugenie Ahangama Date: Thu, 16 Apr 2026 21:32:49 +0100 Subject: [PATCH 3/6] fix: load script as ES module, add delete message element --- debugging/book-library/index.html | 35 +++++++++++++------------------ 1 file changed, 15 insertions(+), 20 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index b57fe5cd..7e66e26e 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,12 +1,12 @@ - My Book Library + My Book Library @@ -31,7 +31,7 @@

Library

Library /> Library class="form-control" id="pages" name="pages" + min="1" required />
+ + @@ -80,17 +83,9 @@

Library

- - - - - - - - - +
- + From c47f47caf8da2b20b8f2e3f32ba931ad85f5296f Mon Sep 17 00:00:00 2001 From: Eugenie Ahangama Date: Thu, 16 Apr 2026 21:33:04 +0100 Subject: [PATCH 4/6] refactor: fix bugs, improve naming, replace alert with inline message --- debugging/book-library/script.js | 144 ++++++++++++++++--------------- 1 file changed, 74 insertions(+), 70 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 9d1adc01..db63145d 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,103 +1,107 @@ let myLibrary = []; -window.addEventListener("load", function (e) { +// DOM node variables +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const checkInput = document.getElementById("check"); +const tableBody = document.getElementById("table-body"); +const deleteMsg = document.getElementById("delete-msg"); +const submitBtn = document.getElementById("submit-btn"); + +// Moved submit listener here since type="module" isolates scope from global +submitBtn.addEventListener("click", submit); + +window.addEventListener("load", function () { + // Removed extra render() call + // — populateStorage() already calls it internally populateStorage(); - render(); }); function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( - "The Old Man and the Sea", - "Ernest Hemingway", - "127", - true + if (myLibrary.length === 0) { + // Page counts stored as numbers, not strings + myLibrary.push(new Book("Robinson Crusoe", "Daniel Defoe", 252, true)); + myLibrary.push( + new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true) ); - myLibrary.push(book1); - myLibrary.push(book2); render(); } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +function Book(title, author, pages, check) { + this.title = title; + this.author = author; + this.pages = pages; + this.check = check; +} //check the right input from forms and if its ok -> add the new book (object in array) //via Book function and start render function function submit() { - if ( - title.value == null || - author.value == "" || - pages.value == null || - pages.value == "" - ) { + const titleVal = titleInput.value.trim(); + const authorVal = authorInput.value.trim(); + const pagesRaw = pagesInput.value; + + // Reject blank or whitespace-only title/author + if (titleVal === "" || authorVal === "" || pagesRaw === "") { alert("Please fill all fields!"); - return false; - } else { - let book = new Book(title.value, author.value, pages.value, check.checked); - myLibrary.push(book); - render(); + return; } -} -function Book(title, author, pages, check) { - this.title = title; - this.author = author; - this.pages = pages; - this.check = check; + // Normalise page count to a number + const pagesNum = parseInt(pagesRaw, 10); + if (isNaN(pagesNum) || pagesNum < 1) { + alert("Please enter a valid page count."); + return; + } + + myLibrary.push(new Book(titleVal, authorVal, pagesNum, checkInput.checked)); + render(); } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n--) { - table.deleteRow(n); - } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; + // Clear all rows in one operation instead of one by one + tableBody.innerHTML = ""; + + for (let i = 0; i < myLibrary.length; i++) { + const row = tableBody.insertRow(); + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const deleteCell = row.insertCell(4); + + titleCell.textContent = myLibrary[i].title; + authorCell.textContent = myLibrary[i].author; + pagesCell.textContent = myLibrary[i].pages; //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; - changeBut.className = "btn btn-success"; - wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == true) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; - - changeBut.addEventListener("click", function () { + const changeBtn = document.createElement("button"); + changeBtn.className = "btn btn-success"; + changeBtn.textContent = myLibrary[i].check ? "Yes" : "No"; + wasReadCell.appendChild(changeBtn); + + changeBtn.addEventListener("click", function () { myLibrary[i].check = !myLibrary[i].check; render(); }); //add delete button to every row and render again - let delBut = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("click", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + const delBtn = document.createElement("button"); + delBtn.className = "btn btn-warning"; + delBtn.textContent = "Delete"; + deleteCell.appendChild(delBtn); + + delBtn.addEventListener("click", function () { + const deletedTitle = myLibrary[i].title; myLibrary.splice(i, 1); render(); + deleteMsg.textContent = `You've deleted: "${deletedTitle}"`; + deleteMsg.style.display = "block"; + setTimeout(() => { + deleteMsg.style.display = "none"; + }, 3000); }); } } From 1470f1165f638e633d758d08144b13d657d1813e Mon Sep 17 00:00:00 2001 From: Eugenie Ahangama Date: Sat, 18 Apr 2026 11:33:34 +0100 Subject: [PATCH 5/6] Declare myLibrary with const --- debugging/book-library/script.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index db63145d..9b0bc141 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,4 +1,4 @@ -let myLibrary = []; +const myLibrary = []; // DOM node variables const titleInput = document.getElementById("title"); From da55ed228885fc50df2755a661a84831f1925064 Mon Sep 17 00:00:00 2001 From: Eugenie Ahangama Date: Sat, 18 Apr 2026 11:47:23 +0100 Subject: [PATCH 6/6] Consolidate load handler and fix stale comment --- debugging/book-library/script.js | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 9b0bc141..c32a514a 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -9,13 +9,11 @@ const tableBody = document.getElementById("table-body"); const deleteMsg = document.getElementById("delete-msg"); const submitBtn = document.getElementById("submit-btn"); -// Moved submit listener here since type="module" isolates scope from global -submitBtn.addEventListener("click", submit); - window.addEventListener("load", function () { - // Removed extra render() call - // — populateStorage() already calls it internally + submitBtn.addEventListener("click", submit); + // Populate default books, then draw the table populateStorage(); + render(); }); function populateStorage() { @@ -25,7 +23,6 @@ function populateStorage() { myLibrary.push( new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true) ); - render(); } }