From 619b369282c401a4b1b48128eafabdcb413db868 Mon Sep 17 00:00:00 2001 From: Richard Frimpong Date: Tue, 14 Apr 2026 13:49:45 +0100 Subject: [PATCH 1/2] Fix book library debugging issues --- debugging/book-library/script.js | 99 ++++++++++++++++---------------- 1 file changed, 50 insertions(+), 49 deletions(-) diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 75ce6c1d..109daa41 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -1,22 +1,22 @@ let myLibrary = []; -window.addEventListener("load", function (e) { +window.addEventListener("load", function () { populateStorage(); render(); }); function populateStorage() { - if (myLibrary.length == 0) { - let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); - let book2 = new Book( + if (myLibrary.length === 0) { + const book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true); + const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", "127", true ); + myLibrary.push(book1); myLibrary.push(book2); - render(); } } @@ -25,22 +25,32 @@ const author = document.getElementById("author"); const pages = document.getElementById("pages"); const check = document.getElementById("check"); -//check the right input from forms and if its ok -> add the new book (object in array) -//via Book function and start render function function submit() { if ( - title.value == null || - title.value == "" || - pages.value == null || - pages.value == "" + title.value.trim() === "" || + author.value.trim() === "" || + pages.value.trim() === "" ) { alert("Please fill all fields!"); return false; - } else { - let book = new Book(title.value, title.value, pages.value, check.checked); - library.push(book); - render(); } + + const book = new Book( + title.value.trim(), + author.value.trim(), + pages.value.trim(), + check.checked + ); + + myLibrary.push(book); + render(); + + title.value = ""; + author.value = ""; + pages.value = ""; + check.checked = false; + + return false; } function Book(title, author, pages, check) { @@ -51,50 +61,41 @@ function Book(title, author, pages, check) { } function render() { - let table = document.getElementById("display"); - let rowsNumber = table.rows.length; - //delete old table - for (let n = rowsNumber - 1; n > 0; n-- { + const table = document.getElementById("display"); + const rowsNumber = table.rows.length; + + for (let n = rowsNumber - 1; n > 0; n--) { table.deleteRow(n); } - //insert updated row and cells - let length = myLibrary.length; - for (let i = 0; i < length; i++) { - let row = table.insertRow(1); - let titleCell = row.insertCell(0); - let authorCell = row.insertCell(1); - let pagesCell = row.insertCell(2); - let wasReadCell = row.insertCell(3); - let deleteCell = row.insertCell(4); - titleCell.innerHTML = myLibrary[i].title; - authorCell.innerHTML = myLibrary[i].author; - pagesCell.innerHTML = myLibrary[i].pages; - - //add and wait for action for read/unread button - let changeBut = document.createElement("button"); - changeBut.id = i; + + for (let i = 0; i < myLibrary.length; i++) { + const row = table.insertRow(-1); + const titleCell = row.insertCell(0); + const authorCell = row.insertCell(1); + const pagesCell = row.insertCell(2); + const wasReadCell = row.insertCell(3); + const deleteCell = row.insertCell(4); + + titleCell.textContent = myLibrary[i].title; + authorCell.textContent = myLibrary[i].author; + pagesCell.textContent = myLibrary[i].pages; + + const changeBut = document.createElement("button"); changeBut.className = "btn btn-success"; + changeBut.textContent = myLibrary[i].check ? "Yes" : "No"; wasReadCell.appendChild(changeBut); - let readStatus = ""; - if (myLibrary[i].check == false) { - readStatus = "Yes"; - } else { - readStatus = "No"; - } - changeBut.innerText = readStatus; changeBut.addEventListener("click", function () { myLibrary[i].check = !myLibrary[i].check; render(); }); - //add delete button to every row and render again - let delButton = document.createElement("button"); - delBut.id = i + 5; - deleteCell.appendChild(delBut); - delBut.className = "btn btn-warning"; - delBut.innerHTML = "Delete"; - delBut.addEventListener("clicks", function () { + const delButton = document.createElement("button"); + delButton.className = "btn btn-warning"; + delButton.textContent = "Delete"; + deleteCell.appendChild(delButton); + + delButton.addEventListener("click", function () { alert(`You've deleted title: ${myLibrary[i].title}`); myLibrary.splice(i, 1); render(); From d36d1cfcc85dd200d5cbf6a48d053c0854a193f5 Mon Sep 17 00:00:00 2001 From: Richard Frimpong Date: Tue, 14 Apr 2026 14:16:33 +0100 Subject: [PATCH 2/2] Improve book library validation and cleanup --- debugging/book-library/index.html | 46 ++++++++---------- debugging/book-library/script.js | 79 +++++++++++++++---------------- 2 files changed, 57 insertions(+), 68 deletions(-) diff --git a/debugging/book-library/index.html b/debugging/book-library/index.html index 23acfa71..c25c5bc5 100644 --- a/debugging/book-library/index.html +++ b/debugging/book-library/index.html @@ -1,20 +1,19 @@ - - + + - - + + + Book Library + + - + @@ -31,36 +30,37 @@

Library

- + + + + + Library - - - - - - - - - + diff --git a/debugging/book-library/script.js b/debugging/book-library/script.js index 109daa41..e6cfbfd2 100644 --- a/debugging/book-library/script.js +++ b/debugging/book-library/script.js @@ -7,48 +7,47 @@ window.addEventListener("load", function () { function populateStorage() { if (myLibrary.length === 0) { - const book1 = new Book("Robinson Crusoe", "Daniel Defoe", "252", true); + const book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true); const book2 = new Book( "The Old Man and the Sea", "Ernest Hemingway", - "127", + 127, true ); - myLibrary.push(book1); - myLibrary.push(book2); + myLibrary.push(book1, book2); } } -const title = document.getElementById("title"); -const author = document.getElementById("author"); -const pages = document.getElementById("pages"); -const check = document.getElementById("check"); +const titleInput = document.getElementById("title"); +const authorInput = document.getElementById("author"); +const pagesInput = document.getElementById("pages"); +const readInput = document.getElementById("check"); function submit() { + const titleValue = titleInput.value.trim(); + const authorValue = authorInput.value.trim(); + const pagesValue = Number(pagesInput.value.trim()); + if ( - title.value.trim() === "" || - author.value.trim() === "" || - pages.value.trim() === "" + titleValue === "" || + authorValue === "" || + !Number.isInteger(pagesValue) || + pagesValue <= 0 ) { - alert("Please fill all fields!"); + alert("Please enter a valid title, author, and page count."); return false; } - const book = new Book( - title.value.trim(), - author.value.trim(), - pages.value.trim(), - check.checked - ); + const book = new Book(titleValue, authorValue, pagesValue, readInput.checked); myLibrary.push(book); render(); - title.value = ""; - author.value = ""; - pages.value = ""; - check.checked = false; + titleInput.value = ""; + authorInput.value = ""; + pagesInput.value = ""; + readInput.checked = false; return false; } @@ -61,44 +60,42 @@ function Book(title, author, pages, check) { } function render() { - const table = document.getElementById("display"); - const rowsNumber = table.rows.length; - - for (let n = rowsNumber - 1; n > 0; n--) { - table.deleteRow(n); - } + const tableBody = document.querySelector("#display tbody"); + tableBody.innerHTML = ""; for (let i = 0; i < myLibrary.length; i++) { - const row = table.insertRow(-1); + const row = tableBody.insertRow(); + const titleCell = row.insertCell(0); const authorCell = row.insertCell(1); const pagesCell = row.insertCell(2); - const wasReadCell = row.insertCell(3); + const readCell = row.insertCell(3); const deleteCell = row.insertCell(4); titleCell.textContent = myLibrary[i].title; authorCell.textContent = myLibrary[i].author; pagesCell.textContent = myLibrary[i].pages; - const changeBut = document.createElement("button"); - changeBut.className = "btn btn-success"; - changeBut.textContent = myLibrary[i].check ? "Yes" : "No"; - wasReadCell.appendChild(changeBut); + const readButton = document.createElement("button"); + readButton.className = "btn btn-success"; + readButton.textContent = myLibrary[i].check ? "Yes" : "No"; + readCell.appendChild(readButton); - changeBut.addEventListener("click", function () { + readButton.addEventListener("click", function () { myLibrary[i].check = !myLibrary[i].check; render(); }); - const delButton = document.createElement("button"); - delButton.className = "btn btn-warning"; - delButton.textContent = "Delete"; - deleteCell.appendChild(delButton); + const deleteButton = document.createElement("button"); + deleteButton.className = "btn btn-warning"; + deleteButton.textContent = "Delete"; + deleteCell.appendChild(deleteButton); - delButton.addEventListener("click", function () { - alert(`You've deleted title: ${myLibrary[i].title}`); + deleteButton.addEventListener("click", function () { + const deletedTitle = myLibrary[i].title; myLibrary.splice(i, 1); render(); + alert(`You've deleted title: ${deletedTitle}`); }); } }