You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Upstream Viceroy published viceroy-lib@0.16.6, which bumped its MSRV to rustc 1.95. rust-toolchain.toml pins this repo to rustc 1.91.1, so any cargo install --git https://github.com/fastly/Viceroy viceroy (no tag) now fails at compile:
error: failed to compile `viceroy v0.16.6 (https://github.com/fastly/Viceroy#9900324b)`
Caused by:
rustc 1.91.1 is not supported by the following package:
viceroy-lib@0.16.6 requires rustc 1.95
Immediate fix
#656 pins .github/workflows/test.yml to --tag v0.16.4, matching the tag already used by .github/actions/setup-integration-test-env/action.yml. This unbreaks CI.
Follow-up this issue tracks
The pin is a workaround, not a resolution. We should:
Decide the ongoing strategy for keeping Viceroy current given the MSRV gap — either bump the repo's rustc pin to something Viceroy supports, or continue pinning Viceroy to a compatible tag and track upstream releases deliberately.
Consolidate the Viceroy version into a single source of truth so .github/workflows/test.yml and .github/actions/setup-integration-test-env/action.yml can't drift. (e.g., a repo variable, a .viceroy-version file read by both, or a composite action.)
Add a CI step or dependabot rule that flags when Viceroy ships a new tag that is incompatible with our rustc pin, so we catch this before the gap widens further.
What's wrong
Upstream Viceroy published
viceroy-lib@0.16.6, which bumped its MSRV to rustc 1.95.rust-toolchain.tomlpins this repo to rustc 1.91.1, so anycargo install --git https://github.com/fastly/Viceroy viceroy(no tag) now fails at compile:Immediate fix
#656 pins
.github/workflows/test.ymlto--tag v0.16.4, matching the tag already used by.github/actions/setup-integration-test-env/action.yml. This unbreaks CI.Follow-up this issue tracks
The pin is a workaround, not a resolution. We should:
.github/workflows/test.ymland.github/actions/setup-integration-test-env/action.ymlcan't drift. (e.g., a repo variable, a.viceroy-versionfile read by both, or a composite action.)References
rust-toolchain.toml— current rustc pin (1.91.1)..github/workflows/test.yml— the workflow that was pinning by movingHEAD..github/actions/setup-integration-test-env/action.yml— already pinned tov0.16.4.