One of our researchers ran the unit test and got the error
======================================================================
FAIL: test_genslip_fftw (test_genslip.TestGenslip)
Test GP rupture generator for the correct FFTW behavior
----------------------------------------------------------------------
Traceback (most recent call last):
File "/project/6001152/bbp/bbp-22.4.0/bbp/tests/test_genslip.py", line 132, in test_genslip_fftw
self.assertFalse(not cmp_bbp.cmp_srf(a_ref_file, a_newfile,
AssertionError: True is not false : Output file /home/tyson/projects/def-tyson/bbp/bbp_data/tmpdata/5201715/5201715_nr_eq.srf does not match reference file /home/tyson/projects/def-tyson/bbp/bbp-22.4.0/bbp/tests/ref_data/gp/m6.73-0.10x0.10_s2379646.srf
Running the comparison manually gives (is there any way to get the output from the cmp_bbp routine from the unit test script?)
Plane 0, point 186: point parameters in field 4 disagree.
The relevant lines from the files are
-118.434769 34.303387 5.16943e+00 116 44 1.00000e+08 8.352078e+00 1.00000e-01 3.35000e+05 2.70000e+00
79 77.4399 23 0.0000 0 0.0000 0
-118.434769 34.303387 5.16943e+00 115 44 1.00000e+08 8.352078e+00 1.00000e-01 3.35000e+05 2.70000e+00
79 77.4399 23 0.0000 0 0.0000 0
so it seems the issue is that the strike angle disagree by 1 degree.
Examining the cmp_bbp routine reveals they are expected to agree to PP_TOLERANCE = 0.011, which is pretty meaningless given they are only output to the degree. Seems there should either at least two decimals output or an ANGLE_TOLERANCE = 1 added and used to compare strike and dip.
One of our researchers ran the unit test and got the error
Running the comparison manually gives (is there any way to get the output from the
cmp_bbproutine from the unit test script?)The relevant lines from the files are
so it seems the issue is that the strike angle disagree by 1 degree.
Examining the
cmp_bbproutine reveals they are expected to agree toPP_TOLERANCE = 0.011, which is pretty meaningless given they are only output to the degree. Seems there should either at least two decimals output or anANGLE_TOLERANCE = 1added and used to compare strike and dip.