From c4b05aedf7c10e01f2b8bcbe58e73630b42e67f3 Mon Sep 17 00:00:00 2001 From: Tim Saucer Date: Fri, 10 Apr 2026 15:17:34 -0400 Subject: [PATCH 1/4] Set rust flags on windows release verification --- .github/workflows/verify-release-candidate.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/verify-release-candidate.yml b/.github/workflows/verify-release-candidate.yml index a10a4faa9..34b7c12b4 100644 --- a/.github/workflows/verify-release-candidate.yml +++ b/.github/workflows/verify-release-candidate.yml @@ -73,6 +73,11 @@ jobs: version: "27.4" repo-token: ${{ secrets.GITHUB_TOKEN }} + - name: Set RUSTFLAGS for Windows GNU linker + if: matrix.os == 'windows' + shell: bash + run: echo "RUSTFLAGS=-C link-arg=--exclude-libs=ALL" >> "$GITHUB_ENV" + - name: Run release candidate verification shell: bash run: ./dev/release/verify-release-candidate.sh "${{ inputs.version }}" "${{ inputs.rc_number }}" From 8b99f73e9f7e59e5943b42cfbed190b91cf44b64 Mon Sep 17 00:00:00 2001 From: Tim Saucer Date: Fri, 10 Apr 2026 15:30:09 -0400 Subject: [PATCH 2/4] Forward flag to linker --- .github/workflows/verify-release-candidate.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/verify-release-candidate.yml b/.github/workflows/verify-release-candidate.yml index 34b7c12b4..7a5deff5b 100644 --- a/.github/workflows/verify-release-candidate.yml +++ b/.github/workflows/verify-release-candidate.yml @@ -76,7 +76,7 @@ jobs: - name: Set RUSTFLAGS for Windows GNU linker if: matrix.os == 'windows' shell: bash - run: echo "RUSTFLAGS=-C link-arg=--exclude-libs=ALL" >> "$GITHUB_ENV" + run: echo "RUSTFLAGS=-C link-arg=-Wl,--exclude-libs=ALL" >> "$GITHUB_ENV" - name: Run release candidate verification shell: bash From 9879fc7dbe066098445b9600087e665435b58f8a Mon Sep 17 00:00:00 2001 From: Tim Saucer Date: Fri, 10 Apr 2026 15:36:12 -0400 Subject: [PATCH 3/4] Switch to msvc rust toolchain --- .github/workflows/verify-release-candidate.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verify-release-candidate.yml b/.github/workflows/verify-release-candidate.yml index 7a5deff5b..e306ea91d 100644 --- a/.github/workflows/verify-release-candidate.yml +++ b/.github/workflows/verify-release-candidate.yml @@ -73,10 +73,10 @@ jobs: version: "27.4" repo-token: ${{ secrets.GITHUB_TOKEN }} - - name: Set RUSTFLAGS for Windows GNU linker + - name: Switch to MSVC Rust toolchain (Windows) if: matrix.os == 'windows' shell: bash - run: echo "RUSTFLAGS=-C link-arg=-Wl,--exclude-libs=ALL" >> "$GITHUB_ENV" + run: rustup default stable-x86_64-pc-windows-msvc - name: Run release candidate verification shell: bash From 038fe60aaf596c3bea04f31b4cc6e96f51a06395 Mon Sep 17 00:00:00 2001 From: Tim Saucer Date: Fri, 10 Apr 2026 16:37:08 -0400 Subject: [PATCH 4/4] Revert "Switch to msvc rust toolchain" This reverts commit 9879fc7dbe066098445b9600087e665435b58f8a. --- .github/workflows/verify-release-candidate.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/verify-release-candidate.yml b/.github/workflows/verify-release-candidate.yml index e306ea91d..7a5deff5b 100644 --- a/.github/workflows/verify-release-candidate.yml +++ b/.github/workflows/verify-release-candidate.yml @@ -73,10 +73,10 @@ jobs: version: "27.4" repo-token: ${{ secrets.GITHUB_TOKEN }} - - name: Switch to MSVC Rust toolchain (Windows) + - name: Set RUSTFLAGS for Windows GNU linker if: matrix.os == 'windows' shell: bash - run: rustup default stable-x86_64-pc-windows-msvc + run: echo "RUSTFLAGS=-C link-arg=-Wl,--exclude-libs=ALL" >> "$GITHUB_ENV" - name: Run release candidate verification shell: bash