🐛 `lint/nursery/useNullishCoalescing` not working properly in `2.4.11`

[jakeleventhal]

Environment information

Details

▶ bun biome rage                                                                                                                                                                  
CLI:
  Version:                      2.4.11
  Color support:                true

Platform:
  CPU Architecture:             aarch64
  OS:                           macos

Environment:
  BIOME_LOG_PATH:                    unset
  BIOME_LOG_PREFIX_NAME:             unset
  BIOME_LOG_LEVEL:                   unset
  BIOME_LOG_KIND:                    unset
  BIOME_CONFIG_PATH:                 unset
  BIOME_THREADS:                     unset
  BIOME_WATCHER_KIND:                unset
  BIOME_WATCHER_POLLING_INTERVAL:    unset
  NO_COLOR:                     unset
  TERM:                         xterm-256color
  JS_RUNTIME_VERSION:           v24.12.0
  JS_RUNTIME_NAME:              node
  NODE_PACKAGE_MANAGER:         bun/1.3.12

Biome Configuration:
  Status:                       Loaded successfully
  Path:                         biome.jsonc
  Formatter enabled:            true
  Linter enabled:               true
  Assist enabled:               true
  VCS enabled:                  true
  HTML full support enabled:    unset

Workspace:
  Open Documents:               0

What happened?

biome check . --write --unsafe --error-on-warnings

export const normalizeTaxRegistrationValue = (
	value: string | null | undefined,
) =>
	// `""` = not configured, `null` = user explicitly does not have one.
	value === undefined ? "" : value;

Expected result

This should not trigger a diagnostic. It wants me to use nullish coallescing for
this but this changes behavior.

Code of Conduct

• I agree to follow Biome's Code of Conduct

[github-actions]

Hello @jakeleventhal, please provide a minimal reproduction. You can use one of the following options:

• Provide a link to our playground, if it's applicable.
• Provide a link to GitHub repository. To easily create a reproduction, you can use our interactive CLI via npm create @biomejs/biome-reproduction

Issues marked with S-Needs repro will be closed if they have no activity within 3 days.

[jakeleventhal]

https://biomejs.dev/playground/?lineWidth=120&indentStyle=space&whitespaceSensitivity=strict&indentScriptAndStyle=true&lintRules=useNullishCoalescing&analyzerFixMode=safeAndUnsafeFixes&tab=formatter&pane=Console&code=ZQB4AHAAbwByAHQAIABjAG8AbgBzAHQAIABuAG8AcgBtAGEAbABpAHoAZQBUAGEAeABSAGUAZwBpAHMAdAByAGEAdABpAG8AbgBWAGEAbAB1AGUAIAA9ACAAKAAKAAkAdgBhAGwAdQBlADoAIABzAHQAcgBpAG4AZwAgAHwAIABuAHUAbABsACAAfAAgAHUAbgBkAGUAZgBpAG4AZQBkACwACgApACAAPQA%2BAAoACQAvAC8AIABgACIAIgBgACAAPQAgAG4AbwB0ACAAYwBvAG4AZgBpAGcAdQByAGUAZAAsACAAYABuAHUAbABsAGAAIAA9ACAAdQBzAGUAcgAgAGUAeABwAGwAaQBjAGkAdABsAHkAIABkAG8AZQBzACAAbgBvAHQAIABoAGEAdgBlACAAbwBuAGUALgAKAAkAdgBhAGwAdQBlACAAPQA9AD0AIAB1AG4AZABlAGYAaQBuAGUAZAAgAD8AIAAiACIAIAA6ACAAdgBhAGwAdQBlADsA&ruleDomains.react=all&ruleDomains.test=all&ruleDomains.solid=all&ruleDomains.next=all&ruleDomains.project=all

[dyc3]

I think the rule is correct, wouldn't you rewrite this as:

value ?? "";