js/api/ApiProvider.js appears to misspell cmd.command as cmd.commmand in the websocket message handler.
Current code:
update: cmd.commmand == 'window_update'
and
update: cmd.commmand == 'layout_update'
Because of the typo, these checks always evaluate to false, so the update flag passed to downstream handlers is incorrect.
This seems to affect at least:
window_update
layout_update
For example, onWindowMessage in js/main.js uses this flag to decide whether to route through updateWindow(cmd) or addPaneBatched(cmd), so this appears to affect runtime behavior rather than just dead code.
Suggested fix: replace cmd.commmand with cmd.command in both locations.
js/api/ApiProvider.jsappears to misspellcmd.commandascmd.commmandin the websocket message handler.Current code:
and
Because of the typo, these checks always evaluate to
false, so theupdateflag passed to downstream handlers is incorrect.This seems to affect at least:
window_updatelayout_updateFor example,
onWindowMessageinjs/main.jsuses this flag to decide whether to route throughupdateWindow(cmd)oraddPaneBatched(cmd), so this appears to affect runtime behavior rather than just dead code.Suggested fix: replace
cmd.commmandwithcmd.commandin both locations.