Merge pull request #67 from github/copilot/fix-code-for-review-comments

Fix cross-platform process creation in tests: use `cmd /c more` on Windows

Author: edburns

src/test/java/com/github/copilot/sdk/CliServerManagerTest.java

@@ -70,13 +70,18 @@ void connectToServerTcpMode() throws Exception {
         }
     }
 
+    private static Process startBlockingProcess() throws IOException {
+        boolean isWindows = System.getProperty("os.name").toLowerCase().contains("windows");
+        return (isWindows ? new ProcessBuilder("cmd", "/c", "more") : new ProcessBuilder("cat")).start();
+    }
+
     @Test
     void connectToServerStdioMode() throws Exception {
         var options = new CopilotClientOptions();
         var manager = new CliServerManager(options);
 
         // Create a dummy process for stdio mode
-        Process process = new ProcessBuilder("cat").start();
+        Process process = startBlockingProcess();
         try {
             JsonRpcClient client = manager.connectToServer(process, null, null);
             assertNotNull(client);

src/test/java/com/github/copilot/sdk/JsonRpcClientTest.java

@@ -133,17 +133,22 @@ void testIsConnectedWithSocketClosed() throws Exception {
         pair.serverSocket.close();
     }
 
+    private static Process startBlockingProcess() throws IOException {
+        boolean isWindows = System.getProperty("os.name").toLowerCase().contains("windows");
+        return (isWindows ? new ProcessBuilder("cmd", "/c", "more") : new ProcessBuilder("cat")).start();
+    }
+
     @Test
     void testIsConnectedWithProcess() throws Exception {
-        Process proc = new ProcessBuilder("cat").start();
+        Process proc = startBlockingProcess();
         try (var client = JsonRpcClient.fromProcess(proc)) {
             assertTrue(client.isConnected());
         }
     }
 
     @Test
     void testIsConnectedWithProcessDead() throws Exception {
-        Process proc = new ProcessBuilder("cat").start();
+        Process proc = startBlockingProcess();
         var client = JsonRpcClient.fromProcess(proc);
         proc.destroy();
         proc.waitFor(5, TimeUnit.SECONDS);
@@ -155,7 +160,7 @@ void testIsConnectedWithProcessDead() throws Exception {
 
     @Test
     void testGetProcessReturnsProcess() throws Exception {
-        Process proc = new ProcessBuilder("cat").start();
+        Process proc = startBlockingProcess();
         try (var client = JsonRpcClient.fromProcess(proc)) {
             assertSame(proc, client.getProcess());
         }