Always send FileFilteredResults to prevent infinite re-request loop

When loadFileFilteredResults could not produce results (e.g. 0-row table,
graph table, or no displayed query), it sent results: undefined which the
webview ignored, leaving it in the loading state and causing repeated
re-requests on every render.

Now always send a FileFilteredResults object so the webview marks the
request as completed. Made SetFileFilteredResultsMsg.results non-optional
to enforce this at the type level.

Author: asgerf

extensions/ql-vscode/src/common/interface-types.ts

@@ -271,7 +271,7 @@ export interface FileFilteredResults {
 
 interface SetFileFilteredResultsMsg {
   t: "setFileFilteredResults";
-  results: FileFilteredResults | undefined;
+  results: FileFilteredResults;
 }
 
 /**

extensions/ql-vscode/src/local-queries/results-view.ts

@@ -1177,6 +1177,10 @@ export class ResultsView extends AbstractWebview<
   ): Promise<void> {
     const query = this._displayedQuery;
     if (!query) {
+      void this.postMessage({
+        t: "setFileFilteredResults",
+        results: { fileUri, selectedTable },
+      });
       return;
     }
 
@@ -1230,15 +1234,12 @@ export class ResultsView extends AbstractWebview<
 
     void this.postMessage({
       t: "setFileFilteredResults",
-      results:
-        rawRows !== undefined || sarifResults !== undefined
-          ? {
-              fileUri,
-              selectedTable,
-              rawRows,
-              sarifResults,
-            }
-          : undefined,
+      results: {
+        fileUri,
+        selectedTable,
+        rawRows,
+        sarifResults,
+      },
     });
   }
 

extensions/ql-vscode/src/view/results/ResultsApp.tsx

@@ -276,21 +276,20 @@ export function ResultsApp() {
           }
           break;
 
-        case "setFileFilteredResults":
-          if (msg.results != null) {
-            const results = msg.results;
-            setState((prev) => {
-              if (
-                results.fileUri === prev.editorSelection?.fileUri &&
-                results.selectedTable === prev.selectedTable &&
-                prev.fileFilteredResults === undefined
-              ) {
-                return { ...prev, fileFilteredResults: results };
-              }
-              return prev;
-            });
-          }
+        case "setFileFilteredResults": {
+          const results = msg.results;
+          setState((prev) => {
+            if (
+              results.fileUri === prev.editorSelection?.fileUri &&
+              results.selectedTable === prev.selectedTable &&
+              prev.fileFilteredResults === undefined
+            ) {
+              return { ...prev, fileFilteredResults: results };
+            }
+            return prev;
+          });
           break;
+        }
 
         default:
           assertNever(msg);