Building with --format cjs and --no-bundle ignores cjs format

[CosmoCreeper]

What version of Bun is running?

1.3.5+1e86cebd7

What platform is your computer?

Microsoft Windows NT 10.0.26200.0 x64

What steps can reproduce the bug?

Create a TypeScript file with some simple imports and exports and build it with a specific build command:
bun build ./index.ts --outfile ./index.js --target node --format cjs --no-bundle

What is the expected behavior?

I'm looking to be able to output a file that is still readable and uses external imports, meanwhile being compatible with CommonJS.

What do you see instead?

An ESM JS file using import and export features.

Additional information

No response

[robobun]

✅ Reproduced. Fix in #29190 — --format cjs --no-bundle now routes ESM imports/exports through the CommonJS printer. Covers export function/class, export const/let/var (incl. nested destructuring), export default, export * from, export { ... } from, and ES2022 string-literal export names.

[robobun]

Thanks for testing! The previous commits handled every export form but I'd missed the s_import handler entirely — it was still emitting raw import statements regardless of format. Fixed in b7924a1: the --no-bundle --format cjs path now rewrites import to require too (simple destructuring, no runtime helpers). Could you rebuild and retest? The new output for your example should be:

var { readFileSync } = require("fs");
var path = require("path");
function hello() {
  console.log("Hello", readFileSync, path);
}
Object.defineProperty(module.exports, "hello", { get: () => hello, enumerable: true, configurable: true });

[CosmoCreeper]

Nice job! Can confirm that it's working perfectly now!
Not sure why you commented here when I replied in the pull request though. Regardless it looks good.

[robobun]

Thanks — that's exactly it. printCommonJS was using a NoOpRenamer unconditionally because historically it was only called from the bundler path (after the linker had already run). On the new no-bundle path the parser runs with minify_identifiers on but never gets a renamer. Fixed in 451c9ba: mirrored printAst"'s MinifyRenamer" setup in printCommonJS", and updated printBundledExportsForBinding" to read symbol.original_name" for the Object.defineProperty" key (external contract) and `renamer.nameForSymbol(ref)" for the getter target (local), so only the local binding shrinks under minify.