From c2c5e953fb71e599e5d821c705884d1304ce4be4 Mon Sep 17 00:00:00 2001 From: Benny Powers Date: Thu, 16 Apr 2026 17:11:22 +0300 Subject: [PATCH 1/3] fix(label): only thicken border on link hover, not close button Use #container:has(#link:hover) instead of :host(:hover) so the border only thickens when hovering the link text itself, not when hovering the close button. Matches PFv4 behavior. Assisted-By: Claude Opus 4.6 (1M context) --- elements/pf-label/pf-label.css | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/elements/pf-label/pf-label.css b/elements/pf-label/pf-label.css index 000d70205a..141bf28080 100644 --- a/elements/pf-label/pf-label.css +++ b/elements/pf-label/pf-label.css @@ -305,15 +305,8 @@ pf-button { cursor: pointer; } -:host(:hover) #link ~ *, -:host(:focus-within) #link ~ *, -#link:hover, -#link:focus { - cursor: pointer; -} - -:host(:hover) #container:has(#link)::before, -:host(:focus-within) #container:has(#link)::before { +#container:has(#link:hover)::before, +#container:has(#link:focus)::before { border-width: var(--pf-c-label__content--link--hover--before--BorderWidth, 2px); border-color: var(--_label-link-hover-border-color); } From b25698be7dcd05fe49ab86a963fbff94bb7b3f14 Mon Sep 17 00:00:00 2001 From: Benny Powers Date: Thu, 16 Apr 2026 18:52:12 +0300 Subject: [PATCH 2/3] fix(label): use overflow clip to avoid cutting off focus outlines Replace overflow: hidden with overflow: clip and overflow-clip-margin so focus outlines on the close button are not clipped. Assisted-By: Claude Opus 4.6 (1M context) --- elements/pf-label/pf-label.css | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/elements/pf-label/pf-label.css b/elements/pf-label/pf-label.css index 141bf28080..03959d7b80 100644 --- a/elements/pf-label/pf-label.css +++ b/elements/pf-label/pf-label.css @@ -20,7 +20,8 @@ pf-icon, ::slotted(pf-icon) { } #container { - overflow: hidden; + overflow: clip; + overflow-clip-margin: 3px; text-overflow: ellipsis; white-space: nowrap; border-width: 0; From 8d15bf3d2b720c2904f8144fb0726dc18f5d3b04 Mon Sep 17 00:00:00 2001 From: Adam Johnson Date: Thu, 16 Apr 2026 12:03:25 -0400 Subject: [PATCH 3/3] fix(label): increase overflow clip margin --- elements/pf-label/pf-label.css | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/elements/pf-label/pf-label.css b/elements/pf-label/pf-label.css index 03959d7b80..4861072d2a 100644 --- a/elements/pf-label/pf-label.css +++ b/elements/pf-label/pf-label.css @@ -21,7 +21,7 @@ pf-icon, ::slotted(pf-icon) { #container { overflow: clip; - overflow-clip-margin: 3px; + overflow-clip-margin: 6px; text-overflow: ellipsis; white-space: nowrap; border-width: 0;