grid_map: fix compile issues with ROS2#520
Open
sssarana wants to merge 1 commit intoANYbotics:rollingfrom
Open
grid_map: fix compile issues with ROS2#520sssarana wants to merge 1 commit intoANYbotics:rollingfrom
sssarana wants to merge 1 commit intoANYbotics:rollingfrom
Conversation
- include correct header files for `cv_bridge`; - updated CMake files to properly add dependencies; - updated CMake to add definitions for `eigen` plugins correctly; - add dependency on `grid_map_core` for demos and rviz plugin; - corrected outdated use of `send_timestamp` in ROS converter;
Ryanf55
requested changes
Apr 17, 2026
Collaborator
Ryanf55
left a comment
Ryanf55
left a comment
There was a problem hiding this comment.
Sorry, I don't think all the patches here are right.
Please submit separate patches for the things that are still valid.
| rclcpp::rclcpp | ||
| ${sensor_msgs_TARGETS} | ||
| ament_target_dependencies(${PROJECT_NAME} SYSTEM | ||
| ${dependencies} |
Collaborator
There was a problem hiding this comment.
This is backwards, we should link to exported namespace targets. If any are missing, add them.
|
|
||
| // ROS | ||
| #include <cv_bridge/cv_bridge.hpp> | ||
| #include <cv_bridge/cv_bridge.h> |
Collaborator
There was a problem hiding this comment.
I think your library is out of date. rolling uses the hpp extension.
https://github.com/ros-perception/vision_opencv/blob/rolling/cv_bridge/include/cv_bridge/cv_bridge.hpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cv_bridge;eigenplugins correctly;grid_map_corefor demos and rviz plugin;send_timestampin ROS converter;