zipper merge algebra (join/meet/subtract)#33
Merged
luketpeterson merged 10 commits intomasterfrom Apr 13, 2026
Merged
Conversation
marcin-rzeznicki
requested review from
Adam-Vandervorst,
imlvts and
luketpeterson
Owner
|
Except for it only being implemented on ReadZipperUntracked, LGTM. I believe the next steps are also pretty clear for lifting this out of experimental: specializing graft children, making versions available for stronger (with nodeid) and weaker (without graft) zippers. |
Collaborator
|
I don't have any serious issues with this. Sounds like it's better to land it now and deal with specific nits as we move forward. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains zipper merge algebra (join/meet/subtract)
Implements stackless zipper-based join, meet, and difference. Adds
ZipperAlgebraExtfor ergonomicmethod calls.