[O2B-1534] Migrate log overview to use filtering model pattern by NarrowsProjects · Pull Request #2083 · AliceO2Group/Bookkeeping

NarrowsProjects · 2026-02-20T11:53:37Z

I have a JIRA ticket

branch and/or PR name(s) include(s) JIRA ID
issue has "Fix version" assigned
issue "Status" is set to "In review"
PR labels are selected

Notable changes for users:

Individual from-to selectors on the logs page have been replaced with a single field that will open the standard time range selector
All open-input forms apply their filters when focus is lost on them.

Notable changes for developers:

All filters have been moved to a filteringModel in logsOverviewModel
The filters for runs, lhcfills and environments have been renamed under the hood to match getAllRunsUseCase:
- runs => runNumbers
- lhcFills => fillNumbers
- environments => environmentIds

Changes made to the database:

none

codecov · 2026-02-20T11:55:29Z

Codecov Report

❌ Patch coverage is 34.78261% with 30 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.76%. Comparing base (47203c7) to head (c768ba5).

Files with missing lines	Patch %	Lines
...ib/public/views/Logs/Overview/LogsOverviewModel.js	0.00%	11 Missing ⚠️
...blic/views/Logs/ActiveColumns/logsActiveColumns.js	0.00%	8 Missing ⚠️
...nts/Filters/LogsFilter/author/AuthorFilterModel.js	0.00%	6 Missing ⚠️
...mponents/Filters/LogsFilter/author/authorFilter.js	0.00%	3 Missing ⚠️
...ic/components/Filters/common/filters/textFilter.js	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2083      +/-   ##
==========================================
+ Coverage   43.78%   45.76%   +1.97%     
==========================================
  Files        1044     1042       -2     
  Lines       17353    17213     -140     
  Branches     3149     3119      -30     
==========================================
+ Hits         7598     7877     +279     
+ Misses       9755     9336     -419

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… anything

…for length

… filter popover

…by rootOnly

…FilteringModel-pattern

graduta · 2026-04-16T13:44:54Z

+         * @param {FilteringModel} logOverviewModel.filteringModel filtering model
+         * @return {Component} the filter component
+         */
+        filter: ({ filteringModel }) => rawTextFilter(


What about re-using the runNumbersFilter in this case?

I don't see much use in making or using individual components for each filter that uses rawTextFilter that are virtually Identical.

What I do think is a good idea now that you mention it is to make a new component that would cover most of these usecases and change it for special cases such as authorFilter. Something like

export const textInputFilter = (filteringModel, identifier, placeholder) => rawTextFilter(filteringModel.get(identifier), { classes: ['w-100', identifier], placeholder });

Which would then shorten these filter creations to:

filter: ({ filteringModel }) => textInputFilter(filteringModel, 'runNumbers', 'e.g. 553203, 553221, ...'),

graduta · 2026-04-16T13:46:08Z

+         * @return {Component} the filter component
+         */
+        filter: ({ filteringModel }) => rawTextFilter(
+            filteringModel.get('environmentIds'),


Similar question, I see that runsActiveColumns also has the environmentIds as rawtextFilter
Could we perhaps extract as a reusable component similar to runNumbersFilter?

graduta · 2026-04-16T13:46:20Z

+         * @param {FilteringModel} logOverviewModel.filteringModel filtering model
+         * @return {Component} the filter component
+         */
+        filter: ({ filteringModel }) => rawTextFilter(


graduta · 2026-04-16T13:47:05Z

    }

-    if (filter.run?.values?.length > 0) {
+    if (runNumbers) {


Should we not still check if array is not empty?

From what I can remember, there is no way for runNumber to arrive here as an empty array.
The joy DTO requires it to be a string of numbers, and an empty string will be rejected

I've done some manual tests, and I can't find a way to reach that line as an empty array

graduta · 2026-04-16T13:47:46Z

    }

-    if (filter.lhcFills?.values?.length > 0) {
+    if (fillNumbers) {


Should we not still check if array is not empty?
We could define on L54 as fillNumbers = [] and straight away check length perhaps?

graduta · 2026-04-16T13:47:52Z


-    if (filter.environments?.values?.length > 0) {
-        const validEnvironments = await EnvironmentRepository.findAll({ where: { id: { [Op.in]: filter.environments.values } } });
+    if (environmentIds) {


graduta · 2026-04-16T13:48:30Z

-    values: CustomJoi.stringArray().items(EntityIdDto).single().required(),
-    operation: Joi.string().valid('and', 'or').required(),
-});
+const RunFilterDto = CustomJoi.stringArray().items(EntityIdDto).single();


I see these RunFilter, Environment, LHC being used across DTOs with different matching criterias.
What about extracting this in its own DTO and reuse across DTOs?

I will have a look to see if they can be standardised

Guust added 4 commits February 20, 2026 10:23

chore: remove redundant model assignment.

722caf7

chore: move all filters denoted as so to a filteringModel

f161cae

Make filterInputModel extend filterModel

9faffaf

rename inputfilter to ParsedInputFilter

247943b

NarrowsProjects self-assigned this Feb 20, 2026

NarrowsProjects requested a review from graduta as a code owner February 20, 2026 11:53

NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Feb 20, 2026

NarrowsProjects marked this pull request as draft February 20, 2026 11:53

implement authorfilter with ParsedInputFilterModel changes

114285d

NarrowsProjects force-pushed the improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern branch from 07567e2 to 114285d Compare February 20, 2026 12:02

Guust added 9 commits February 20, 2026 13:18

re-implement filter

f39f7ae

add tag-filters to the filtering object

df1fea3

replace titleFilter and contentFilter with RawTextFilterModels

96ca85f

make Authorfilter an implementation of RawTextFilterModel

93b3291

add runs filter to the filteringmodel

5a5e830

add environments filter to the filteringmodel

b5e7148

add lhcFills filter to the filteringmodel

3507ba0

add created filter to the filteringmodel

9c63409

move the sort 'filter' to fetchlogs, since it doesn't actually filter…

5500b3e

… anything

NarrowsProjects force-pushed the improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern branch from a936a03 to 5500b3e Compare February 20, 2026 16:24

Guust added 7 commits February 21, 2026 16:57

change filter to rawTextFilter for title

a09ae8b

fix test by changing event type to 'change'

512999b

fix content and author tests

0f15812

import openFilteringPanel and resetFilters

7b641ca

fix createdAt filter test

5ab8218

change event types to change

4c96d73

fix isAnyFilterActive

18ce4dc

NarrowsProjects marked this pull request as ready for review February 21, 2026 18:22

NarrowsProjects force-pushed the improv/O2B-1534/Migrate-Log-Overview-to-use-FilteringModel-pattern branch from 3cd62d0 to 370c475 Compare April 13, 2026 13:19