Skip to content

[PWGDQ] Improve memory consumption of DQ filter task#15783

Merged
lucamicheletti93 merged 2 commits intoAliceO2Group:masterfrom
fgrosa:dq_opt
Apr 16, 2026
Merged

[PWGDQ] Improve memory consumption of DQ filter task#15783
lucamicheletti93 merged 2 commits intoAliceO2Group:masterfrom
fgrosa:dq_opt

Conversation

@fgrosa
Copy link
Copy Markdown
Collaborator

@fgrosa fgrosa commented Apr 15, 2026

Memory improvement for DQ filter, as discussed in the trigger meeting today: https://indico.cern.ch/event/1674294/?note=378937#27-general-news-2026-menu
@lupengzhong @lucamicheletti93

@github-actions github-actions bot added the pwgdq label Apr 15, 2026
@github-actions github-actions bot changed the title Improve memory consumption of DQ filter task [PWGDQ] Improve memory consumption of DQ filter task Apr 15, 2026
@github-actions
Copy link
Copy Markdown

O2 linter results: ❌ 111 errors, ⚠️ 130 warnings, 🔕 0 disabled

@lupengzhong
Copy link
Copy Markdown
Contributor

lupengzhong commented Apr 15, 2026

Hi @fgrosa,

I have checked the new and old AnalysisResults.root files that you produced with this PR or not. As you mentioned in today’s trigger meeting, I can confirm that the two outputs are identical, and all the necessary information for the trigger QA is included in the new root file. I am able to generate the same QA plots with both root files.

@lucamicheletti93
Copy link
Copy Markdown
Collaborator

Thanks @fgrosa ! The modifications looks fine to me. Just one extra comment, if you want to add this modification to the new tag for the trigger probably you need to include also this PR: #15784 . It avoids the increase of memory consumption due to the load of the full geometry.

@fgrosa
Copy link
Copy Markdown
Collaborator Author

fgrosa commented Apr 16, 2026

Thanks @fgrosa ! The modifications looks fine to me. Just one extra comment, if you want to add this modification to the new tag for the trigger probably you need to include also this PR: #15784 . It avoids the increase of memory consumption due to the load of the full geometry.

Hi @lucamicheletti93, thanks but I don't need to include also the other one, since I will only cherry-pick this on top of the current CEFP tag. Can you please approve this one if it's good for you? Thanks!

@lucamicheletti93
Copy link
Copy Markdown
Collaborator

@fgrosa Thanks for the clarification!! I have approved it 😉

@lucamicheletti93 lucamicheletti93 merged commit 7812b5d into AliceO2Group:master Apr 16, 2026
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants