[PWGCF] Add circle PID cut#15810
Conversation
huinaibing
commented
Apr 16, 2026
huinaibing
commented
- add a circle PID cut
- fix a bug in PID graph filling
huinaibing
requested review from
alibuild,
jaelpark,
otonvd,
shouqiye,
victor-gonzalez and
wenyaCern
as code owners
|
O2 linter results: ❌ 0 errors, |
… linter, and fixed the magic number issue.
vkucera
left a comment
vkucera
left a comment
There was a problem hiding this comment.
Don't revert the include fixes.
Please consider the following formatting changes to AliceO2Group#15810
Thank you for your comment, Professor. I was using |
pre-commit does not change your list of includes. You just did not rebase on upstream properly. |
Thanks for the correction, Professor. I just noticed there was a header file change a few hours ago. I’ve added the header I need（If I don't add it, megalinter throws an error） while keeping the original headers intact. |
| if (pt > ptMin && pt < ptMax) { | ||
| // Circular cut: sqrt(TPC^2 + TOF^2) < 2 | ||
| isPion = (tpcNsigma * tpcNsigma + tofNsigma * tofNsigma) < circleCutOpts.cfgCircleCutSigmaSquarePi.value; | ||
| } else { | ||
| // Fallback: TPC only cut | ||
| isPion = std::fabs(tpcNsigma) < circleCutOpts.cfgCircleCutTPCPi.value; | ||
| } |
There was a problem hiding this comment.
Can this not just be a function or lambda? You repeat the same thing for each species.
Please consider the following formatting changes to AliceO2Group#15810
4 participants
