Skip to content

chore: Upgrade to Angular 20 and other dependencies#192

Open
robinsonzimmermann wants to merge 1 commit intomainfrom
chore/upgrade-angular
Open

chore: Upgrade to Angular 20 and other dependencies#192
robinsonzimmermann wants to merge 1 commit intomainfrom
chore/upgrade-angular

Conversation

@robinsonzimmermann
Copy link
Copy Markdown
Collaborator

No description provided.

@robinsonzimmermann robinsonzimmermann requested a review from a team as a code owner April 21, 2026 11:55
Copy link
Copy Markdown
Member

@Puigcerber Puigcerber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be happier if imports were sorted by package name but otherwise seems fine.

export class TableOfContentComponent implements AfterViewInit {
@ViewChild(MatTree) tree?: MatTree<HeaderNode>;

_headers: HeaderNode[] = [];
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The _ implies private so I think you should mark it as such and use a getter for the template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants