fix: ignore EditorOnly hierarchy in validator#779
Open
hai-vr wants to merge 1 commit intoBasisVR:developerfrom
Open
fix: ignore EditorOnly hierarchy in validator#779hai-vr wants to merge 1 commit intoBasisVR:developerfrom
hai-vr wants to merge 1 commit intoBasisVR:developerfrom
Conversation
During avatar build, all GameObject hierarchy tagged with EditorOnly is removed from the avatar (before NDMF even runs). Therefore, only collect components pertaining to transforms that will exist during the build for the validation of Renderers, SkinnedMeshRenderers, and Transforms.
Contributor
|
Putting my two cents, if you doing test-in-editor for the avatar those objects will still be there and could break the system if not properly accounted for... |
Contributor
|
It would better if we did a build hook that properly accounts for those objects. |
Contributor
Author
Afaik Test in Editor also removes those EditorOnly objects |
Contributor
|
Okay don't see any other issue as the basis avatar for the "before" prefab is not running. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During avatar build, all GameObject hierarchy tagged with EditorOnly is removed from the avatar (before NDMF even runs). Therefore, only collect components pertaining to transforms that will exist during the build for the validation of Renderers, SkinnedMeshRenderers, and Transforms.