Open
Conversation
Add CraftEngineCustomBlock, CraftEngineListener, and register them in AOneBlock.onLoad() following the same pattern as Nexo and ItemsAdder integrations. Add craft-engine-bukkit dependency to pom.xml. Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/98ee3d0c-05a3-457b-8bce-42c0463fde3a Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/98ee3d0c-05a3-457b-8bce-42c0463fde3a Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
… Nexo custom blocks Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/e3aa31a3-2d63-45e5-acdb-c2662dfd773b Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
…-in-oneblock docs: strengthen README documentation for MythicMobs, ItemsAdder, and Nexo custom blocks
The craft-engine-bukkit API references types from craft-engine-core (Key, CustomBlock), so both modules are needed on the compile classpath. Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/02b4b996-4f28-499b-accc-6899a91de52a Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
…aftengine Add CraftEngine custom block support
Agent-Logs-Url: https://github.com/BentoBoxWorld/AOneBlock/sessions/a5034e3a-0d17-43d8-9b85-048ac0c0dcf9 Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
…ders Return defaults for empty placeholders when player has no island
Sync 17 locale files with en-US.yml by adding 6 missing keys (actionbar status/not-active, actionbar command description/toggle messages, and my-island-phase-default placeholder). Russian only needed 1 key. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ndencies Add sections for dependency source lookup workflow, full project layout of sibling repositories under ~/git/, and key dependency source locations. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…anager Extract helper methods to bring all four SonarCloud HIGH-severity cognitive complexity violations (java:S3776) below the threshold of 15: - BlockListener.onPlayerInteract (16→≤15): extract updateBrushSession - OneBlocksManager.initBlock (18→≤15): extract checkNotDuplicate - OneBlocksManager.addMobs (17→≤15): extract resolveEntityType + processMobEntry - OneBlocksManager.addBlocks (16→≤15): extract processBlockMapEntry No behaviour change. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Stream.toList() in CheckPhase, OneBlockPhase, OneBlocksManager (S6204) - Proper JUnit assertions in BlockListenerTest2 (S5785) - Remove useless local variable assignments in BlockListenerTest2 (S1854) - Add missing @OverRide to setUp/tearDown in test classes (S1161) - Remove commented-out code in 5 test files (S125) - Rename restricted identifier 'record' to 'mobRecord' in MythicMobCustomBlock (S6213) - Add since/forRemoval to @deprecated in ChunkGeneratorWorld and Settings (S6355, S1123) - Remove always-true e.getTo() != null in StartSafetyListener (S2589) - Remove always-false user == null check in LocationStatsHandler (S2589) - Replace deprecated PlayerQuitEvent(Player,String) constructor in tests (S5738) - Replace deprecated EntityExplodeEvent null arg with ExplosionResult.DESTROY (S5738) - Replace deprecated Biome.name() with getKey().getKey() (S5738) - Use Map.computeIfAbsent in updateBrushSession (S3824) - Convert anonymous Runnable to lambda in startContinuousBrush (S1604) - Remove unused 'phase' parameter from handlePhaseChange (S1172) - Add reason to @disabled on testInitBlock (S1607) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- S116: rename MOB_ASPECTS → mobAspects in WarningSounder (instance field, not constant) - S1874: replace deprecated Registry.BIOME with RegistryAccess.registryAccess().getRegistry(RegistryKey.BIOME) in OneBlocksManager - S1874: replace deprecated Util.translateColorCodes with raw text in HoloListener - S1874: replace deprecated display.setText with display.text(Component) via LegacyComponentSerializer - S1874: replace deprecated ChatColor.COLOR_CHAR with '\u00A7' in PhasesPanel; remove unused ChatColor import - S2637: fix @nullable Player in BlockListener.breakBlock — early return instead of Objects.requireNonNull - S2637: extract Location in BossBarListener.onJoin to avoid repeated @nullable call - S2637: save user.getPlayer() to local variable in CheckPhase before calling showTitle - S3577: suppress S3577 on BlockListenerTest2 and OneBlocksManagerTest3 (intentional numbered suffixes) - S1874: suppress deprecation on FixedMetadataValue in CommonTestSetup - S1128: remove unused imports (BlockState, BlockData, Entity, Event, eq) - S6068: remove useless eq() wrappers in BlockListenerTest2 - S1612: revert ambiguous method reference in CommonTestSetup (toLegacyText is overloaded) - S1130: suppress unnecessary throws warning on setUp() - S1607: add reason to @disabled in OneBlocksManagerTest3 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolves SonarCloud security hotspot — using a mutable tag reference allows the action to change under us. Pinned to the SHA of v2. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Extract location to local variable before the inWorld check so a single non-null reference flows through both the guard and the getIslandAt call. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The Surefire <argLine> was hardcoded, silently overwriting the
argLine property that jacoco:prepare-agent sets. Changed to use
@{argLine} late-binding prefix so the JaCoCo Java agent is correctly
prepended to the JVM arguments at test execution time.
Also added sonar.coverage.jacoco.xmlReportPaths to make the report
path explicit for SonarCloud.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.