refactor: use BentoBox CraftEngineHook instead of direct API calls#503
Open
tastybento wants to merge 1 commit intodevelopfrom
Open
refactor: use BentoBox CraftEngineHook instead of direct API calls#503tastybento wants to merge 1 commit intodevelopfrom
tastybento wants to merge 1 commit intodevelopfrom
Conversation
CraftEngineCustomBlock now delegates to CraftEngineHook static methods instead of importing CraftEngine classes directly. Removes the craft-engine-core compile dependency (craft-engine-bukkit is still needed for CraftEngineListener). Bumps bentobox.version to 3.15.0-SNAPSHOT. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CraftEngineCustomBlocknow delegates toCraftEngineHookstatic methods from BentoBox instead of importing CraftEngine classes directlycraft-engine-corecompile dependency (no longer needed);craft-engine-bukkitis kept forCraftEngineListenerbentobox.versionto3.15.0-SNAPSHOT(requires feat: add CraftEngineHook for centralised custom block support BentoBox#2952)Context
BentoBoxWorld/BentoBox#2952 introduced
CraftEngineHookas a centralised hook for CraftEngine, following the same pattern asItemsAdderHookandOraxenHook. This PR removes the direct CraftEngine API calls from AOneBlock so the addon no longer needs to track CraftEngine's internal API independently of BentoBox.Depends on: BentoBoxWorld/BentoBox#2952
Test plan
type: craftenginemap form) loads correctlyCraftEngineReloadEventstill triggers AOneBlock phase reload viaCraftEngineListener🤖 Generated with Claude Code