Localise 'hand' keyword in donate/value commands; sync locales#415
Closed
tastybento wants to merge 1 commit intomasterfrom
Closed
Localise 'hand' keyword in donate/value commands; sync locales#415tastybento wants to merge 1 commit intomasterfrom
tastybento wants to merge 1 commit intomasterfrom
Conversation
…locales - Add island.donate.hand.keyword locale key (en-US: "hand") so each language can provide its own word for the hand subcommand arg - IslandDonateCommand: accept both English "hand" and the localized keyword; tab-complete shows the localized keyword - IslandValueCommand: same localizable keyword for HAND arg and tab-complete - All 16 non-English locales: add island.donate.hand.keyword (translated) and island.donate.invalid-item (translated) - uk.yml: fully translate donate section (parameters, description, all messages) and update value command parameters/description Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Member
Author
|
Duplicate of #416 which has been merged into develop. Changes will reach master via the normal release process. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IslandDonateCommandandIslandValueCommandnow read the subcommand keyword from the locale keyisland.donate.hand.keyword(default"hand"). English"hand"is always accepted as a fallback for backward compatibility; the localized word is an additional accepted form. Tab-complete shows the localized keyword.island.donate.hand.keywordand the previously missingisland.donate.invalid-itemto all 16 non-English locale files with translated values.donatesection inuk.ymlwas translated (it previously had English placeholder values), and thevaluecommand parameters/description were updated to use the Ukrainian word for "hand" (рука).Test plan
mvn test— 175 tests, 0 failures/ai donate рукаaccepts the Ukrainian keyword and triggers hand-donation flow/ai donate handstill works (English fallback)/ai donateshows the localized keyword/ai value рукаshows value of held item in Ukrainian locale/ai helpshows fully translated donate description and parameters in Ukrainian🤖 Generated with Claude Code