python-codex32 reference impl#74
Open
BenWestgate wants to merge 1 commit intoBlockstreamResearch:masterfrom
Open
python-codex32 reference impl#74BenWestgate wants to merge 1 commit intoBlockstreamResearch:masterfrom
BenWestgate wants to merge 1 commit intoBlockstreamResearch:masterfrom
Conversation
From: https://github.com/BenWestgate/python-codex32 Published on PyPI: https://pypi.org/project/codex32/
Contributor
|
I vote to merge this with a cursory review; later when I improve rust-codex32, I will steal all the test vectors from this implementation, and presumably if they pass on both implementations, they're both correct :P. cursory review ACK 4857e18 -- checked that this is shaped like it does codex32 stuff, that there's nothing obviously malicious, no filesystem or network access, etc. cc @roconnor-blockstream can you let me know if I should hold off on merging this? Fine to ping me out-of-band. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apoelstra/rust-codex32#2 (comment):
I have wrote this python implementation that covers more tests than the rust one does. It also does the approach above and relies on general checksum and bech32 modules. So it also passes Bech32/Bech32m tests.
It includes new test vectors for bitcoin/bips#2040 and bitcoin/bips#2077.
From: https://github.com/BenWestgate/python-codex32
Published on PyPI: https://pypi.org/project/codex32/