Move the Jet codec and parser towards the object-safaty#358
Draft
ivanlele wants to merge 2 commits intoBlockstreamResearch:masterfrom
Draft
Move the Jet codec and parser towards the object-safaty#358ivanlele wants to merge 2 commits intoBlockstreamResearch:masterfrom
ivanlele wants to merge 2 commits intoBlockstreamResearch:masterfrom
Conversation
Contributor
Author
|
@apoelstra. Looks big at first glance, but it's mostly from moving the decoding tree into autogenerated files, once I revert those, it'll be tiny. Also the updated generation: BlockstreamResearch/simplicity#335 |
ivanlele
force-pushed
the
feature/sail-jet-from-not-object-safe-supertraits
branch
from
fa8df6c to
701e61b
Compare
ivanlele
force-pushed
the
feature/sail-jet-from-not-object-safe-supertraits
branch
from
701e61b to
4d89a8f
Compare
Collaborator
|
utACK 4d89a8f -- looking forward to getting the Simplicity PR in (I fixed my pinning so hopefully I can merge it today) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the
Jet::decodemethod toJetEnvironment::decode_jet, introduces aparsemethod for jets within that environment, and updatesJet::encodeto comply with object safety. See #349 for details.