Skip to content

Fixes Cost.__add__ returning references #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxnus wants to merge 1 commit into
base: develop
Choose a base branch
from
+1 −5
Open

Fixes Cost.__add__ returning references #244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions sc2/game_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,15 +325,11 @@ def __bool__(self) -> bool:
return self.minerals != 0 or self.vespene != 0

def __add__(self, other: Cost) -> Cost:
if not other:
return self
if not self:
return other
time = (self.time or 0) + (other.time or 0)
return Cost(self.minerals + other.minerals, self.vespene + other.vespene, time=time)

def __sub__(self, other: Cost) -> Cost:
time = (self.time or 0) + (other.time or 0)
time = (self.time or 0) - (other.time or 0)
return Cost(self.minerals - other.minerals, self.vespene - other.vespene, time=time)

def __mul__(self, other: int) -> Cost:
Expand Down
Loading