London|ITP-Jan-2026 |Alexandru Pocovnicu | Sprint 2 | Book library #410
Open
alexandru-pocovnicu wants to merge 30 commits intoCodeYourFuture:mainfrom
Open
London|ITP-Jan-2026 |Alexandru Pocovnicu | Sprint 2 | Book library #410alexandru-pocovnicu wants to merge 30 commits intoCodeYourFuture:mainfrom
alexandru-pocovnicu wants to merge 30 commits intoCodeYourFuture:mainfrom
Conversation
…ality in render function
This comment has been minimized.
This comment has been minimized.
4 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
alexandru-pocovnicu
changed the title
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
alexandru-pocovnicu
changed the title
alexandru-pocovnicu
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
alexandru-pocovnicu
added
Needs Review
cjyuan
reviewed
Apr 7, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
…space in script.js
…n and update button text handling
…tion checks in submit function
alexandru-pocovnicu
added
Needs Review
cjyuan
reviewed
Apr 17, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Just a few more suggestions.
| @@ -2,16 +2,15 @@ let myLibrary = []; | |||
Contributor
There was a problem hiding this comment.
Safer to declare myLibrary using const, as it should not be reassigned another value.
Comment on lines
+22
to
+25
| const titleInput = document.getElementById("title"); | ||
| const authorInput = document.getElementById("author"); | ||
| const pagesInput = document.getElementById("pages"); | ||
| const readCheckbox = document.getElementById("check"); |
Contributor
There was a problem hiding this comment.
Common practice is to declare all shared variables/constants at the beginning of the file.
Comment on lines
84
to
+90
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } else { | ||
| readStatus = "Yes"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
| changeButton.textContent = readStatus; |
Contributor
There was a problem hiding this comment.
This could be a good opportunity to practice using the ? : conditional operator. Can you rewrite the code on lines 84–90 as a single statement?
cjyuan
added
Reviewed
…o the top for better organization
alexandru-pocovnicu
added
Needs Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
debugged the code