Skip to content

London | JAN-ITP-26 | Damian Dunkley | Sprint 2 | Book Library#427

Open
DamianDL wants to merge 13 commits intoCodeYourFuture:mainfrom
DamianDL:Debug
Open

London | JAN-ITP-26 | Damian Dunkley | Sprint 2 | Book Library#427
DamianDL wants to merge 13 commits intoCodeYourFuture:mainfrom
DamianDL:Debug

Conversation

@DamianDL
Copy link
Copy Markdown

@DamianDL DamianDL commented Apr 13, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Bugs fixed

  1. Website loads and shows list of books
  2. Can add a book
  3. Correctly displays title and author name
  4. Delete button works
  5. Correctly stores read books

Code refactored in JS and HTML

Questions

Please review

@DamianDL DamianDL added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Flows The name of the module. labels Apr 14, 2026
@DamianDL DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 15, 2026
cjyuan
cjyuan reviewed Apr 16, 2026
View reviewed changes
Comment thread debugging/book-library/index.html Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js
Comment on lines +48 to +49
titleInput.value = title;
authorInput.value = author;
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why update the input field with the trimmed values? Why not do the same for "pages")?

Copy link
Copy Markdown
Author

@DamianDL DamianDL Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated when changed page length to number

Comment thread debugging/book-library/script.js Outdated
Comment thread debugging/book-library/script.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 16, 2026
@DamianDL DamianDL added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 16, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 16, 2026

Changes look good. Well done.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Data-Flows The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DamianDL @cjyuan