Skip to content

Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 2| Book Library #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MehrozMunir wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Manchester | 26-ITP-Jan | Mehroz Munir | Sprint 2| Book Library #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8d6abd
fixed the bugs in book library
MehrozMunir Apr 13, 2026
86a9ca2
fixed the issues after feedback from pull request
MehrozMunir Apr 17, 2026
cab31a2
type of pages change in the constructor
MehrozMunir Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 25 additions & 25 deletions debugging/book-library/index.html
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://validator.w3.org/, there is an error in your index.html. Can you fix it?

Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
charset="utf-8" >
<meta
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
content="width=device-width, initial-scale=1.0" >
<title>My Book Library</title>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
>
<link rel="stylesheet" type="text/css" href="style.css" >
</head>

<body>
Expand All @@ -28,69 +28,69 @@ <h1>Library</h1>
</button>

<div id="demo" class="collapse">
<form id="bookForm" onsubmit="return addNewBook(event)">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
pattern=".*\S.*"
title="The title cannot be empty or consist only of spaces."
>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
required
/>
pattern="^[A-Za-z\.\-\s]*[A-Za-z\.\-][A-Za-z\.\-\s]*$"
title="Author name must contain letters and cannot be only spaces."
>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
min="1"
step="1"
>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
>
</div>
</form>
</div>

<p id="deleted-row-message"></p>
<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
<th>Delete</th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>

<script src="script.js"></script>
<script src="script.js" ></script>
</body>
</html>
111 changes: 60 additions & 51 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
const book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
const book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
Expand All @@ -20,82 +19,92 @@ function populateStorage() {
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");
const deletedRowMessage = document.getElementById("deleted-row-message");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
function addNewBook(event) {
//Prevent the page from refreshing
event.preventDefault();

const titleInputValue = titleInput.value.toString().trim();
const authorInputValue = authorInput.value.toString().trim();
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
titleInputValue === "" ||
pagesInput.value === "" ||
authorInputValue === ""
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
const book = new Book(
titleInput.value,
authorInput.value,
pagesInput.value,
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.value is a string, and a user can enter a value such as "1.4e2" (a numerical value equals to 140) in the input field.

Copy link
Copy Markdown
Author

@MehrozMunir MehrozMunir Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's true. I have resolved this issue by converting this back to a number when rendering this value, as shown here

pagesCell.textContent = Number(myLibrary[i].pages); //line 81 of script.js

checkInput.checked
);
myLibrary.push(book);
render();
// Clear the form after adding
document.getElementById("bookForm").reset();
}
}

function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.pages = Number(pages);
this.check = check;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
const tableBody = document.querySelector("#display tbody");

//clear old table
tableBody.innerHTML = "";

//insert updated row and cells
let length = myLibrary.length;
const length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const row = tableBody.insertRow();
const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);
titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
const changeButton = document.createElement("button");
changeButton.className = "btn btn-success";
wasReadCell.appendChild(changeButton);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
readStatus = myLibrary[i].check ? "Yes" : "No";
changeButton.innerText = readStatus;

changeBut.addEventListener("click", function () {
changeButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const deleteButton = document.createElement("button");
deleteCell.appendChild(deleteButton);
deleteButton.className = "btn btn-warning";
deleteButton.innerText = "Delete";
deleteButton.addEventListener("click", function () {
deletedRowMessage.classList.remove("hidden-deleted-message");
deletedRowMessage.innerText = `You've deleted the book: ${myLibrary[i].title}`;
// Hide it after 3 seconds
setTimeout(() => {
deletedRowMessage.classList.add("hidden-deleted-message");
}, 3000);
myLibrary.splice(i, 1);
render();
});
Expand Down
14 changes: 14 additions & 0 deletions debugging/book-library/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,17 @@
button.btn-info {
margin: 20px;
}

.jumbotron{
width: 100%;
height: 1%;
padding: 10px 10px 10px 10px;
}
#deleted-row-message{
transition: opacity 0.5s ease;
opacity: 1;
color:red;
}
.hidden-deleted-message {
opacity: 0 !important;
}