Skip to content

London | 26-ITP-January | Eugenie Ahangama | Sprint 2 | Book Library #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eugenie-A wants to merge 6 commits into
base: main
Choose a base branch
from
+87 −91
Open

London | 26-ITP-January | Eugenie Ahangama | Sprint 2 | Book Library #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
689ee5b
Fix empty page title
Eugenie-A Apr 14, 2026
4263d10
Fix book rendering, add/delete bugs and read status logic
Eugenie-A Apr 14, 2026
4eca291
fix: load script as ES module, add delete message element
Eugenie-A Apr 16, 2026
c47f47c
refactor: fix bugs, improve naming, replace alert with inline message
Eugenie-A Apr 16, 2026
1470f11
Declare myLibrary with const
Eugenie-A Apr 18, 2026
da55ed2
Consolidate load handler and fix stale comment
Eugenie-A Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 16 additions & 21 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>My Book Library</title>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
Expand All @@ -31,15 +31,15 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
type="text"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
type="text"
class="form-control"
id="author"
name="author"
Expand All @@ -51,25 +51,28 @@ <h1>Library</h1>
class="form-control"
id="pages"
name="pages"
min="1"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
<input type="checkbox" class="form-check-input" id="check" />Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
id="submit-btn"
/>
</div>
</div>

<div
id="delete-msg"
class="alert alert-warning"
role="alert"
style="display: none; margin: 10px 20px"
></div>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
Expand All @@ -80,17 +83,9 @@ <h1>Library</h1>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
<tbody id="table-body"></tbody>
</table>

<script src="script.js"></script>
<script src="script.js" type="module"></script>
</body>
</html>
141 changes: 71 additions & 70 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,103 +1,104 @@
let myLibrary = [];
const myLibrary = [];

window.addEventListener("load", function (e) {
// DOM node variables
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");
const tableBody = document.getElementById("table-body");
const deleteMsg = document.getElementById("delete-msg");
const submitBtn = document.getElementById("submit-btn");

window.addEventListener("load", function () {
submitBtn.addEventListener("click", submit);
// Populate default books, then draw the table
populateStorage();
render();
});
Comment on lines +12 to 17
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 17, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also place the code that sets up event listener on page load (code on line 13) here.

Copy link
Copy Markdown
Author

@Eugenie-A Eugenie-A Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes as suggested.


function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
if (myLibrary.length === 0) {
// Page counts stored as numbers, not strings
myLibrary.push(new Book("Robinson Crusoe", "Daniel Defoe", 252, true));
myLibrary.push(
new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true)
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
}

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
const titleVal = titleInput.value.trim();
const authorVal = authorInput.value.trim();
const pagesRaw = pagesInput.value;

// Reject blank or whitespace-only title/author
if (titleVal === "" || authorVal === "" || pagesRaw === "") {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
return;
}
}

function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.check = check;
// Normalise page count to a number
const pagesNum = parseInt(pagesRaw, 10);
if (isNaN(pagesNum) || pagesNum < 1) {
alert("Please enter a valid page count.");
return;
}

myLibrary.push(new Book(titleVal, authorVal, pagesNum, checkInput.checked));
render();
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
// Clear all rows in one operation instead of one by one
tableBody.innerHTML = "";

for (let i = 0; i < myLibrary.length; i++) {
const row = tableBody.insertRow();
const titleCell = row.insertCell(0);
const authorCell = row.insertCell(1);
const pagesCell = row.insertCell(2);
const wasReadCell = row.insertCell(3);
const deleteCell = row.insertCell(4);

titleCell.textContent = myLibrary[i].title;
authorCell.textContent = myLibrary[i].author;
pagesCell.textContent = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
const changeBtn = document.createElement("button");
changeBtn.className = "btn btn-success";
changeBtn.textContent = myLibrary[i].check ? "Yes" : "No";
wasReadCell.appendChild(changeBtn);

changeBut.addEventListener("click", function () {
changeBtn.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
const delBtn = document.createElement("button");
delBtn.className = "btn btn-warning";
delBtn.textContent = "Delete";
deleteCell.appendChild(delBtn);

delBtn.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;
myLibrary.splice(i, 1);
render();
deleteMsg.textContent = `You've deleted: "${deletedTitle}"`;
deleteMsg.style.display = "block";
setTimeout(() => {
deleteMsg.style.display = "none";
}, 3000);
});
}
}