Skip to content

London | 26-ITP-Jan | Said Fayaz Sadat | Sprint 2 | Book Library #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fayaz551 wants to merge 4 commits into
base: main
Choose a base branch
from
+138 −159
Open

London | 26-ITP-Jan | Said Fayaz Sadat | Sprint 2 | Book Library #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cf25d1
- Fixed syntax error in render loop (missing closing parenthesis).
fayaz551 Apr 14, 2026
c163676
update input types for better browser compatibility
fayaz551 Apr 14, 2026
087eadc
refine layout for book form and action buttons
fayaz551 Apr 14, 2026
9df271a
clean up redundant logic and implement code best practices.
fayaz551 Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 45 additions & 77 deletions debugging/book-library/index.html
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to https://validator.w3.org/, there are errors in your index.html. Can you fix these errors?

Original file line number Diff line number Diff line change
@@ -1,96 +1,64 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title>My Library</title>
<meta charset="utf-8" name="viewport" content="width=device-width, initial-scale=1.0" />

<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" />
<link rel="stylesheet" type="text/css" href="style.css" />
</head>

<body>
<div class="jumbotron text-center">
<h1>Library</h1>
<p>Add books to your virtual library</p>
<p>Add books to your library</p>
</div>

<button data-toggle="collapse" data-target="#demo" class="btn btn-info">
Add new book
</button>
<div class="container">
<button data-toggle="collapse" data-target="#demo" class="btn btn-info mb-3">
Add new book
</button>

<div id="demo" class="collapse">
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
<div id="demo" class="collapse mb-4">
<div class="card card-body">
<div class="form-group">
<label for="title">Title:</label>
<input type="text" class="form-control" id="title" required />

<label for="author" class="mt-2">Author:</label>
<input type="text" class="form-control" id="author" required />

<label for="pages" class="mt-2">Pages:</label>
<input type="number" class="form-control" id="pages" required />

<div class="form-check mt-3 mb-3">
<input type="checkbox" class="form-check-input" id="check" />
<label class="form-check-label" for="check">I have read this book</label>
</div>

<input type="submit" value="Add to Library" class="btn btn-primary" onclick="submit();" />
</div>
</div>
</div>
</div>

<table class="table" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Number of Pages</th>
<th>Read</th>
<th></th>
</tr>
</thead>
<tbody>
<tr>
<td></td>
<td></td>
<td></td>
<td></td>
<td></td>
</tr>
</tbody>
</table>
<table class="table table-hover" id="display">
<thead class="thead-dark">
<tr>
<th>Title</th>
<th>Author</th>
<th>Pages</th>
<th>Read Status</th>
<th>Actions</th>
</tr>
</thead>
<tbody>
</tbody>
</table>
</div>

<script src="script.js"></script>
</body>
</html>
</html>
130 changes: 58 additions & 72 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,98 +6,84 @@ window.addEventListener("load", function (e) {
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
if (myLibrary.length === 0) {
let book1 = new Book("Robinson Crusoe", "Daniel Defoe", 252, true);
let book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true);
myLibrary.push(book1, book2);

}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const titleInput = document.getElementById("title");
const authorInput = document.getElementById("author");
const pagesInput = document.getElementById("pages");
const checkInput = document.getElementById("check");
Comment on lines +17 to +20
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common practice is to declare all shared constants/variables at the beginning of the file (before function definition).


//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {

const title = titleInput.value.trim();
const author = authorInput.value.trim();
const pages = pagesInput.value;

if (title === "" || author === "" || pages === "") {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
return;
}

const book = new Book(title, author, pages, checkInput.checked);
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan Apr 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can pages be a decimal number?

  • What is the valid range of page count?

myLibrary.push(book);


titleInput.value = "";
authorInput.value = "";
pagesInput.value = "";
checkInput.checked = false;

render();
}

function Book(title, author, pages, check) {
this.title = title;
this.author = author;
this.pages = pages;
this.pages = Number(pages);
this.check = check;
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const tableBody = document.querySelector("#display tbody");


//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
tableBody.innerHTML = "";

myLibrary.forEach((book, i) => {
const row = tableBody.insertRow();


row.insertCell(0).textContent = book.title;
row.insertCell(1).textContent = book.author;
row.insertCell(2).textContent = book.pages;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;

const wasReadCell = row.insertCell(3);
const changeBut = document.createElement("button");
changeBut.className = "btn btn-success";
changeBut.textContent = book.check ? "Yes" : "No";
changeBut.onclick = () => {
book.check = !book.check;
render();
});
};
wasReadCell.appendChild(changeBut);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);

const deleteCell = row.insertCell(4);
const delBut = document.createElement("button");
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
delBut.textContent = "Delete";
delBut.onclick = () => {
myLibrary.splice(i, 1);
render();
});
}
}
console.log(`Deleted: ${book.title}`);
};
deleteCell.appendChild(delBut);
});
}
45 changes: 35 additions & 10 deletions debugging/book-library/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,44 @@
body {
background-color: #f8f9fa;
}

.jumbotron {
background-color: #343a40;
color: white;
border-radius: 0;
}

.container {
margin-top: 20px;
}


.form-group {
width: 400px;
height: 300px;
align-self: left;
padding-left: 20px;
max-width: 500px;
margin: 0 auto;
}


.btn {
display: block;
margin-top: 5px;
}

.form-check-label {
padding-left: 20px;
margin: 5px 0px 5px 0px;

#display {
background-color: white;
box-shadow: 0 4px 8px rgba(0,0,0,0.05);
margin-top: 20px;
}

button.btn-info {
margin: 20px;

.form-check-label {
padding-left: 5px;
cursor: pointer;
}


.btn-success, .btn-warning {
display: inline-block;
margin-right: 5px;
font-size: 0.85rem;
}
Loading