CMP-4248 added compliance checks#14665
Draft
vickeybrown wants to merge 1 commit intoComplianceAsCode:masterfrom
Draft
CMP-4248 added compliance checks#14665vickeybrown wants to merge 1 commit intoComplianceAsCode:masterfrom
vickeybrown wants to merge 1 commit intoComplianceAsCode:masterfrom
Conversation
|
Hi @vickeybrown. Thanks for your PR. I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
New Rules:
package_netcat_removed- Removes nmap-ncat packagepackage_socat_removed- Removes socat packagepackage_python3_dnf_removed- Removes dnf and python3-dnf packagespackage_at_removed- Removes at packageKey Changes:
bash_package_removemacro inshared/macros/10-bash.jinjarpm-ostree override removeinsteadof
dnf removeproducts/rhcos4/profiles/default.profileRationale:
These utilities (netcat, socat, dnf) can be used for legitimate troubleshooting but
present security risks if misused by attackers. RHCOS is designed as an immutable
operating system, and these packages are not installed by default but could be added with
sufficient privileges. Removing them reduces attack surface.
The
atpackage allows scheduling tasks for future execution, which is not needed inRHCOS environments and could be used by attackers to schedule malicious tasks.
Review Hints:
Will fill this out once it's working