Skip to content

Frog color fix #2824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MC-Samuel wants to merge 2 commits into
base: dev
Choose a base branch
from
+4 −1
Open

Frog color fix #2824

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0521bb
frog color fix
MC-Samuel Apr 21, 2026
a5f202f
remove todo
MC-Samuel Apr 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion plugin/src/main/java/com/denizenscript/denizen/utilities/MultiVersionHelper1_19.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,10 @@ public static boolean colorIsApplicable(EntityType type) {
// TODO Frog variants technically have registries on all supported versions
public static String getColor(Entity entity, boolean includeDeprecated) {
if (entity instanceof Frog frog) {
return String.valueOf(frog.getVariant());
if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21)) {
return Utilities.namespacedKeyToString(frog.getVariant().getKey());
}
return frog.getVariant().toString();
}
else if (entity instanceof Boat boat) {
if (NMSHandler.getVersion().isAtLeast(NMSVersion.v1_21)) {
Expand Down