feat: Add cronjob for time-stamper in ConfigMap #1481
Open
feat: Add cronjob for time-stamper in ConfigMap #1481
Conversation
merging personal branch to a new branch.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
==========================================
+ Coverage 95.21% 95.22% +0.01%
==========================================
Files 43 43
Lines 3132 3144 +12
==========================================
+ Hits 2982 2994 +12
Misses 150 150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
Great work so far. The script iterates over all PVCs and annotates any PVC that is mounted as well as any PVC that has no annotation. I'm leaning towards leaving PVCs without annotations alone (last use stamp would technically be incorrect / someone is going to inevitably complain about their old PVCs being messed up by the new system, especially if on by default.) Instead could we just iterate over and mark all mounted PVCs? |
removing the logic for if the pvc wasn't mounted. now only annotates mounted pvcs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
DAQ core plans to implement auto deletion of unused PVC, for this we need a way of telling how long something hasn't been mounted.
Description
By making use of a Cronjob this runs a command every 5 minutes to run a bash script (time-stamper.sh). the bash script loops over the PVC and annotates them, it does this by gathering all PVC's in the blueapi,then all the mounted ones, loops through these annotating the ones that either are mounted or don't have a "last-used" annotation. This is linked via the config map.