chore: improve default error handling 1379 1409#1491
Open
chore: improve default error handling 1379 1409#1491
Conversation
Poor grammar. Co-authored-by: Peter Holloway <peter.holloway@diamond.ac.uk>
… having an effect when running plans - you'll still get the Unauthorised request message"
…ted to return some more details
rebased from main to fix merge conflicts --------- Co-authored-by: Shreelakshmi Iyengar <shreelakshmi.iyengar@diamond.ac.uk> Co-authored-by: Zoheb Shaikh <zoheb.shaikh@diamond.ac.uk> Co-authored-by: Daniel Fernandes <65790536+dan-fernandes@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Zoheb Shaikh <26975142+ZohebShaikh@users.noreply.github.com> Co-authored-by: Abigail Emery <abigail.emery@diamond.ac.uk> Co-authored-by: oliwenmandiamond <136330507+oliwenmandiamond@users.noreply.github.com> Co-authored-by: Peter Holloway <peter.holloway@diamond.ac.uk> Co-authored-by: NeilSmithDLS <118457264+NeilSmithDLS@users.noreply.github.com>
Removed duplicate BlueskyRequestError exception class from rest.py.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1491 +/- ##
==========================================
+ Coverage 95.22% 95.24% +0.01%
==========================================
Files 43 43
Lines 3144 3154 +10
==========================================
+ Hits 2994 3004 +10
Misses 150 150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1379
Fixes #1409
Both issues related to error handling in the REST client.
1379 - Catches 'UnauthorisedAccessErrorexplicitly instead of string-matching onBlueskyRemoteControlError`.
1409 - Expands the exception hierarchy so each
HTTP status code raises a distinct typed exception rather than bundling
everything into BlueskyRemoteControlError.
Tests