ENG-1652 Add .dg.metadata for stable import folder identification#970
ENG-1652 Add .dg.metadata for stable import folder identification#970trangdoan982 wants to merge 4 commits intomainfrom
Conversation
Replace vault-name-based folder matching with spaceUri-based matching to
handle vault renames and name collisions. Each imported folder now gets a
.dg.metadata file with spaceUri, spaceName, and optional userName fields.
- New importFolderMetadata.ts utility: read/write .dg.metadata, build
spaceUri→folderPath map, resolve folders by spaceUri with name-based
fallback and collision-safe folder creation
- Migration on onLoad backfills .dg.metadata for existing folders using
plugin.settings.spaceNames as the source of truth
- importSelectedNodes uses resolveFolderForSpaceUri instead of naive
import/${sanitizedSpaceName} path construction
- Stop writing to plugin.settings.spaceNames (reads kept for migration)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
UI components (NodeTypeSettings, RelationshipTypeSettings, etc.) read plugin.settings.spaceNames via formatImportSource() to display human-readable vault names. Restore the write so new imports don't show truncated vault IDs. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
maparent
left a comment
maparent
left a comment
There was a problem hiding this comment.
Overall look goods, two small changes.
| if (!folderExists) { | ||
| await plugin.app.vault.createFolder(importFolderPath); | ||
| } | ||
| const spaceName = await getSpaceNameFromId(client, spaceId); |
There was a problem hiding this comment.
Realizing that this is another case of a database call within a loop. Can you use getSpaceNameFromIds instead?
| if (!metadata) continue; | ||
|
|
||
| if (map.has(metadata.spaceUri)) { | ||
| console.warn( |
There was a problem hiding this comment.
Let's think of a resolution step here. I would say delete the older metadata file of the two?
2 participants
https://www.loom.com/share/eb8d0f513e0148bda7ee6bef730735cc
Summary
spaceUri-based matching, fixing issues with vault renames and vault name collisions.dg.metadatafile containingspaceUri,spaceName, and optionaluserNameonLoadto backfill.dg.metadatafor existing import folders usingplugin.settings.spaceNamesChanges
importFolderMetadata.ts: utility functions to read/write.dg.metadata, build aspaceUri → folderPathmap by scanningimport/, and resolve folders byspaceUriwith name-based fallback and collision-safe folder creation (import/MyVault-{shortId}/)importSelectedNodes: usesresolveFolderForSpaceUriinstead of constructingimport/${sanitizedSpaceName}directly; handles folder creation and metadata writingimportAssetsForNode: accepts already-resolvedimportBasePathinstead of recomputing fromspaceNameindex.ts: callsmigrateImportFolderMetadatainonLoadImportNodesModal.tsx: stops writing new entries toplugin.settings.spaceNames(reads kept for migration path)Test plan
.dg.metadatais written insideimport/<vaultName>/spaceUriCloses ENG-1652
🤖 Generated with Claude Code