Skip to content

Move LAMMPS hook to a pre_test hook #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bedroge merged 4 commits into from
Apr 22, 2026
+20 −12
Merged

Move LAMMPS hook to a pre_test hook #211

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3df373d
Move lammps hook to a pre_test hook that is specific to LAMMPS, so it…
Apr 21, 2026
0b9435b
Add Easystack to prove this hook still works
Apr 21, 2026
7a30b02
Move stack to rebuilds, as this LAMMPS was already deployed. So we'll…
Apr 21, 2026
3b100c8
Delete easystacks/software.eessi.io/2025.06/rebuilds/eessi-2025.06-eb…
casparvl Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions eb_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1487,6 +1487,25 @@ def pre_test_hook_ignore_failing_tests_FFTWMPI(self, *args, **kwargs):
self.cfg['testopts'] = "|| echo ignoring failing tests"


def pre_test_hook_lammps_ignore_failure_arm_generic(self, *args, **kwargs):
"""
Ignore failing tests on ARM generic target for LAMMPS version 22Jul2025
"""
# Ignore failing ctest for LAMMPS/22Jul2025 on aarch64/generic
cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')
if cpu_target == CPU_TARGET_AARCH64_GENERIC:
if self.name == 'LAMMPS' and self.version == '22Jul2025':
# This command matches what is in
# https://github.com/easybuilders/easybuild-easyblocks/blob/71b010288084e1777fbdd0e3db319f0104134b1d/easybuild/easyblocks/l/lammps.py#L682
# If a test_cmd is already defined, the easyblock linked above should not overwrite it anymore
test_cmd = 'ctest '
test_cmd += '--no-tests=error '
test_cmd += '-LE unstable -E "TestMliapPyUnified|AtomicPairStyle:meam_spline|KSpaceStyle:scafacos.*" '
test_cmd += f' || echo "Ignoring failing tests when installing for {cpu_target}"'
self.log.debug(f"Running tests using test_cmd = '{test_cmd}' as test_cmd")
self.cfg['test_cmd'] = test_cmd


def pre_test_hook_ignore_failing_tests_SciPybundle(self, *args, **kwargs):
"""
Pre-test hook for SciPy-bundle: skip failing tests for selected SciPy-bundle versions
Expand Down Expand Up @@ -1968,18 +1987,6 @@ def post_easyblock_hook(self, *args, **kwargs):
print_warning(f"Not enabling the post_easybuild_hook, as it requires EasyBuild 5.1.1 or newer (you are using {EASYBUILD_VERSION}).")


def pre_run_shell_cmd_hook(cmd, work_dir=None, **kwargs):
"""Main pre_shell_cmd_hook: trigger custom funtions based on software name."""

# Ignore failing ctest for LAMMPS/22Jul2025 on aarch64/generic
cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')
if cpu_target == CPU_TARGET_AARCH64_GENERIC:
if bool(re.search('LAMMPS', work_dir)) and bool(re.search('22Jul2025', work_dir)):
if isinstance(cmd, str) and cmd.startswith('ctest') and '-LE unstable' in cmd:
cmd = cmd + f' || echo "Ignoring failing tests when installing for {cpu_target}"'
return cmd


PARSE_HOOKS = {
'casacore': parse_hook_casacore_disable_vectorize,
'CGAL': parse_hook_cgal_toolchainopts_precise,
Expand Down Expand Up @@ -2037,6 +2044,7 @@ def pre_run_shell_cmd_hook(cmd, work_dir=None, **kwargs):
'ESPResSo': pre_test_hook_ignore_failing_tests_ESPResSo,
'FFTW.MPI': pre_test_hook_ignore_failing_tests_FFTWMPI,
'Highway': pre_test_hook_exclude_failing_test_Highway,
'LAMMPS': pre_test_hook_lammps_ignore_failure_arm_generic,
'SciPy-bundle': pre_test_hook_ignore_failing_tests_SciPybundle,
'netCDF': pre_test_hook_ignore_failing_tests_netCDF,
'OpenBabel': pre_test_hook_ignore_failing_tests_OpenBabel_a64fx,
Expand Down
Loading