Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class support for crediting event contributors and instructors, and exposes these roles through search/facets and Bioschemas CourseInstance JSON-LD output (aligned with issue #993).
Changes:
- Adds
contributorsandinstructorsperson-role associations toEvent, including Solr indexing + facet support. - Extends the event form and extra-metadata display to edit/show these roles.
- Serializes contributors/instructors into the Bioschemas
CourseInstancegenerator and updates/expands tests accordingly.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/models/event_test.rb | Adds model-level tests for assigning contributors/instructors from hashes and Person objects. |
| test/integration/bioschemas_test.rb | Verifies contributors/instructors appear correctly in generated Bioschemas/RDF output. |
| lib/bioschemas/course_instance_generator.rb | Emits schema:contributor and schema:instructor from event people roles. |
| app/views/events/_form.html.erb | Adds form sections to edit contributors and instructors via shared people form partial. |
| app/views/common/_extra_metadata.html.erb | Displays instructors in the extra metadata block. |
| app/views/bioschemas/_preview_button.html.erb | Minor styling change (adds mt-3 class) to preview form. |
| app/models/event.rb | Introduces HasPeople + has_person_role for contributors/instructors; adds Solr fields and facets. |
| app/controllers/events_controller.rb | Permits contributors/instructors in strong params. |
| Gemfile.lock | Updates TeSS_RDF_Extractors git revision and bumps nokogiri patch version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
instructorandcontributorfields ofCourseInstance.Motivation and context
#993
Screenshots
(Paste or upload any relevant screenshots)
Checklist