Let PS format be also _cropable_ from modern mode scripts.#8992
Merged
Let PS format be also _cropable_ from modern mode scripts.#8992
Conversation
See issue #8979 for reference. AFAIK, cropping ps files from a modern mode script never worked. This PR makes it possible (but not an EPS file) but had to change a default value in `gmt_modern.h`. We changed #define GMT_SESSION_CONVERT "A" to #define GMT_SESSION_CONVERT "" Running the tests doesn't reveal any break, but this is nevertheless a somewhat risky change. Fix #8979
Esteban82
approved these changes
Apr 20, 2026
Member
Esteban82
left a comment
Esteban82
left a comment
There was a problem hiding this comment.
I tested it with the following script:
#!/bin/bash
gmt begin test ps,png A,E720,I+m0.1i -C
gmt basemap -R-2/2/-2/2 -JX5i/5i -BNSEW -Bpxa1 -Bpya1 -Xc -Y3.25i
gmt end show
rm -f gmt.conf gmt.history
and I obtained both a cropped PS and PNG.
Esteban82
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #8979 for reference. AFAIK, cropping ps files from a modern mode script never worked. This PR makes it possible (but not an EPS file) but had to change a default value in
gmt_modern.h. We changed#define GMT_SESSION_CONVERT "A"
to
#define GMT_SESSION_CONVERT ""
Running the tests doesn't reveal any break, but this is nevertheless a somewhat risky change.
Fix #8979