fix(bot): reject layouts with empty clusters#74
Open
a9ex wants to merge 1 commit intochore/prettier-eslintfrom
Open
fix(bot): reject layouts with empty clusters#74a9ex wants to merge 1 commit intochore/prettier-eslintfrom
a9ex wants to merge 1 commit intochore/prettier-eslintfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Briefly describe what this PR does:
Adds validation to prevent creating or updating a bot with an empty cluster in its layout.
Context / Motivation
Explain why this change is needed:
The layout validation only checked for duplicate and out-of-range shard IDs.
An empty cluster has no reason to exist, it would run a container with no shards assigned to it.
Related Links
Screenshots (if applicable)
Checklist
Additional Notes