Skip to content

DomNode: fix insertBefore() not dissolving DocumentFragment #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rbri merged 1 commit into from
Apr 16, 2026
+75 −0
Merged

DomNode: fix insertBefore() not dissolving DocumentFragment #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/org/htmlunit/html/DomNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,6 +1008,13 @@ public void insertBefore(final DomNode newNode) {
return;
}

if (newNode instanceof DomDocumentFragment) {
for (final DomNode child : newNode.getChildren()) {
insertBefore(child);
}
return;
}

// clean up the new node, in case it is being moved
if (newNode.getParentNode() != null) {
newNode.detach();
Expand Down
68 changes: 68 additions & 0 deletions src/test/java/org/htmlunit/html/DomNode2Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,4 +167,72 @@ public void textContentCdata() throws Exception {
loadPageVerifyTitle2(content);
}

@Test
@Alerts({"before:new,old", "after:old,new",
"prepend:new,old", "append:old,new", "appendChild:old,new",
"insertBefore:new,old",
"replaceWith:new", "replaceChild:new", "replaceChildren:new"})
public void documentFragment_dissolution() throws Exception {
final String html = DOCTYPE_HTML
+ "<html><head>\n"
+ "<script>\n"
+ LOG_TITLE_FUNCTION
+ "function createFragment() {\n"
+ " var f = document.createDocumentFragment();\n"
+ " var s = document.createElement('span'); s.textContent = 'new';\n"
+ " f.appendChild(s);\n"
+ " return f;\n"
+ "}\n"
+ "function texts(id) {\n"
+ " var el = document.getElementById(id);\n"
+ " var r = [];\n"
+ " for (var i = 0; i < el.children.length; i++) r.push(el.children[i].textContent);\n"
+ " return r.join(',');\n"
+ "}\n"
+ "function test() {\n"
+ " document.getElementById('beforeRef').before(createFragment());\n"
+ " log('before:' + texts('before'));\n"
+ "\n"
+ " document.getElementById('afterRef').after(createFragment());\n"
+ " log('after:' + texts('after'));\n"
+ "\n"
+ " document.getElementById('prepend').prepend(createFragment());\n"
+ " log('prepend:' + texts('prepend'));\n"
+ "\n"
+ " document.getElementById('append').append(createFragment());\n"
+ " log('append:' + texts('append'));\n"
+ "\n"
+ " document.getElementById('appendChild').appendChild(createFragment());\n"
+ " log('appendChild:' + texts('appendChild'));\n"
+ "\n"
+ " document.getElementById('insertBefore')\n"
+ " .insertBefore(createFragment(), document.getElementById('insertBeforeRef'));\n"
+ " log('insertBefore:' + texts('insertBefore'));\n"
+ "\n"
+ " document.getElementById('replaceWithRef').replaceWith(createFragment());\n"
+ " log('replaceWith:' + texts('replaceWith'));\n"
+ "\n"
+ " document.getElementById('replaceChild')\n"
+ " .replaceChild(createFragment(), document.getElementById('replaceChildRef'));\n"
+ " log('replaceChild:' + texts('replaceChild'));\n"
+ "\n"
+ " document.getElementById('replaceChildren').replaceChildren(createFragment());\n"
+ " log('replaceChildren:' + texts('replaceChildren'));\n"
+ "}\n"
+ "</script>\n"
+ "</head><body onload='test()'>\n"
+ "<div id='before'><span id='beforeRef'>old</span></div>\n"
+ "<div id='after'><span id='afterRef'>old</span></div>\n"
+ "<div id='prepend'><span>old</span></div>\n"
+ "<div id='append'><span>old</span></div>\n"
+ "<div id='appendChild'><span>old</span></div>\n"
+ "<div id='insertBefore'><span id='insertBeforeRef'>old</span></div>\n"
+ "<div id='replaceWith'><span id='replaceWithRef'>old</span></div>\n"
+ "<div id='replaceChild'><span id='replaceChildRef'>old</span></div>\n"
+ "<div id='replaceChildren'><span>old</span></div>\n"
+ "</body></html>";

loadPageVerifyTitle2(html);
}

}
Loading