Draft
Conversation
geo2a
force-pushed
the
geo2a/release-11.0
branch
3 times, most recently
from
9241796 to
81ba6a9
Compare
- The experimental hard fork becomes `ProtVer 12` - `ProtVer 11` is not the default
geo2a
force-pushed
the
geo2a/release-11.0
branch
from
81ba6a9 to
857aa7a
Compare
disassembler
approved these changes
Apr 21, 2026
Jimbo4350
approved these changes
Apr 21, 2026
Contributor
There was a problem hiding this comment.
LGTM but there appears to be some RPC related test failures. cc: @carbolymer
There are some failures I will investigate
After ProtVer 12 became the experimental-gated version, Conway-era testnets forged blocks with PV 12 in the header, which the Conway BBody rule rejects (max PV = 11). Dropping the unconditional flag from hardforkViaConfig makes the node fall back to ProtVer 11, which Conway accepts, so the testnet chain progresses.
- Rewrite the singleton-list `++` in hardforkViaConfig as `:` to satisfy hlint's "Use :" hint. - Add scriv fragment documenting the previous commit's disabling of ExperimentalHardForksEnabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bump the
npcExperimentalHardForksEnabled-gated ProtVer to 12ProtVer 12ProtVer 11is now the defaultChecklist
See Running tests for more details
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-9.6andghc-9.12Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.