Merged
Conversation
refactor: add simple flag to `managad_array` because msvc hicks on implace overwrite of abstract classes
tags for choices where stord as pointer not as offset in array
reconstructing globals from a snapshot leaves some state behind, when reconstruction again globals from the same snapshot this data need to be cleared first. refactor: fixes clang compiler warnings
+ disable C++STL, EH and RTTI for CLIB + add c bindnings for story::from_binary and snapshot::from_binary + add compile option INKCPP_NO_STL to generate more standalone lib files
…ve formatted asserts again also added a format message for the endian assert
…ve formatted asserts again also added a format message for the endian assert
Permanent lists are used also as base for variable
Permanent lists are used also as base for variable
Permanent lists are used also as base for variable
JBenda
force-pushed
the
feature/migration
branch
4 times, most recently
from
7ec2389 to
b60309d
Compare
JBenda
force-pushed
the
feature/migration
branch
from
b60309d to
cf6f1aa
Compare
JBenda
force-pushed
the
feature/migration
branch
from
cf6f1aa to
a922651
Compare
Ink Proof ResultsThese results are obtained by running the Ink-Proof Testing Suite on the compiled binaries in this pull request.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the capability to load a snapshot from a previous version of a story.
A created snapshot got an
can_be_migrated()function to check if the snapshot is migratable.Rule of thumb: directly after choosing a choice, before reading any more content, the state should be migratable, as long as you are not in a tunnel.
Best practices also include using a hub knot for snapshots with no local variables, which is guaranteed to be kept around in future versions of the story.
Also, once only choices should get an explicit label, or you know that you will not reorder them, because this would break the tracking.
For more details, feel free to ask or look into
inkcpp\include\snapshot.hFixes: #112
TODO: