Fix/critical stability, security, and logic fixes by Kalebtes2031 · Pull Request #7 · JavaScript-Mastery-Pro/discord-challenge

fix: validate student input by checking safeParse result before database insert

Kalebtes2031

committed

fix: add missing await on Grade.findOneAndUpdate in POST handler

Kalebtes2031

committed

fix: default maxMarks to 100 when not provided to prevent NaN grade calculation

Kalebtes2031

committed

fix: prevent error stack trace leakage in grades API responses

Kalebtes2031

committed

fix: prevent error stack trace leakage in assignments API response

Kalebtes2031

committed

fix: add teacherId filter to students update/delete to prevent unauthorized access

Kalebtes2031

committed

fix: add teacherId filter to announcements update/delete to prevent unauthorized access

Kalebtes2031

committed

fix: add teacherId filter to assignments update/delete to prevent unauthorized access

Kalebtes2031

committed

fix: add teacherId filter and ObjectId validation to grades update/delete

Kalebtes2031

committed

fix: use total count from API instead of capped array length for dashboard student count

Kalebtes2031

committed

fix: correct grade boundary for A+ to use >= 90 instead of > 90

Kalebtes2031

committed

fix: Grade findOneAndUpdate hook now validates marks inside operator

Kalebtes2031

committed

fix: remove userId query param bypass in profile GET to prevent unauthorized access

Kalebtes2031

committed

fix: correct grade point for D from 4 to 5 in dashboard CGPA calculation

Kalebtes2031

committed

fix: Grade updateOne hook now validates marks inside operator

Kalebtes2031

committed

fix: check API response status before processing dashboard data to prevent silent failures

Kalebtes2031

committed

fix: handle negative and zero values in timeAgo to prevent displaying negative timestamps

Kalebtes2031

committed

fix: guard against division by zero in grade percentage calculation

Kalebtes2031

committed

fix: guard against division by zero in API calcGrade function

Kalebtes2031

committed

fix: validate studentId format in attendance GET to prevent 500 errors

Kalebtes2031

committed

fix: validate studentId format in grades GET to prevent 500 errors

Kalebtes2031

committed

fix: validate studentId format in attendance POST (single and bulk) to prevent 500 errors

Kalebtes2031

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/critical stability, security, and logic fixes#7

Fix/critical stability, security, and logic fixes#7
Kalebtes2031 wants to merge 22 commits intoJavaScript-Mastery-Pro:mainfrom
Kalebtes2031:fix/bughunt-kaleb

Commits on Apr 18, 2026

fix: validate student input by checking safeParse result before database insert

fix: add missing await on Grade.findOneAndUpdate in POST handler

fix: default maxMarks to 100 when not provided to prevent NaN grade calculation

fix: prevent error stack trace leakage in grades API responses

fix: prevent error stack trace leakage in assignments API response

fix: add teacherId filter to students update/delete to prevent unauthorized access

fix: add teacherId filter to announcements update/delete to prevent unauthorized access

fix: add teacherId filter to assignments update/delete to prevent unauthorized access

fix: add teacherId filter and ObjectId validation to grades update/delete

fix: use total count from API instead of capped array length for dashboard student count

fix: correct grade boundary for A+ to use >= 90 instead of > 90

fix: Grade findOneAndUpdate hook now validates marks inside operator

fix: remove userId query param bypass in profile GET to prevent unauthorized access

fix: correct grade point for D from 4 to 5 in dashboard CGPA calculation

fix: Grade updateOne hook now validates marks inside operator

fix: check API response status before processing dashboard data to prevent silent failures

fix: handle negative and zero values in timeAgo to prevent displaying negative timestamps

fix: guard against division by zero in grade percentage calculation

fix: guard against division by zero in API calcGrade function

fix: validate studentId format in attendance GET to prevent 500 errors

fix: validate studentId format in grades GET to prevent 500 errors

fix: validate studentId format in attendance POST (single and bulk) to prevent 500 errors