ci: fix backwards compatibility check

.github/workflows/backwards-compatibility.yml

@@ -15,7 +15,7 @@ jobs:
             -   name: Install PHP
                 uses: shivammathur/setup-php@v2
                 with:
-                    php-version: '8.2'
+                    php-version: '8.5'
 
             -   name: Install roave/backward-compatibility-check
                 run: composer require --dev roave/backward-compatibility-check

.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
         strategy:
             fail-fast: false
             matrix:
-                php-versions: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
+                php-versions: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
 
         steps:
             - uses: actions/checkout@v6

composer.json

@@ -37,9 +37,9 @@
         "http-interop/http-factory-guzzle": "^1.0",
         "guzzlehttp/guzzle": "^7.2",
         "php-http/mock-client": "^1.4.1",
-        "phpstan/phpstan": "^0.12.57",
+        "phpstan/phpstan": "^1",
         "phpstan/extension-installer": "^1.0.5",
-        "phpstan/phpstan-deprecation-rules": "^0.12.5",
+        "phpstan/phpstan-deprecation-rules": "^1",
         "phpunit/phpunit": "^8.5 || ^9.4",
         "symfony/phpunit-bridge": "^5.2"
     },

phpstan.neon.dist

@@ -8,8 +8,9 @@ parameters:
     ignoreErrors:
         # Ignore typehint errors on api classes
         -
-            message: '#Method (.*) with no typehint specified\.#'
+            identifier: missingType.return
             path: lib/Github/Api
+
         -
-            message: '#Method (.*) has no return typehint specified\.#'
+            identifier: missingType.parameter
             path: lib/Github/Api

test/Github/Tests/Api/TestCase.php

@@ -42,7 +42,9 @@ protected function getApiMock()
     protected function getMethod($object, $methodName)
     {
         $method = new ReflectionMethod($object, $methodName);
-        $method->setAccessible(true);
+        if (version_compare(PHP_VERSION, '8.5.0', '<')) {
+            $method->setAccessible(true);
+        }
 
         return $method;
     }