<feat>[zwatch]: add GlobalErrorCode and i18n translations for external alert integration#3763
<feat>[zwatch]: add GlobalErrorCode and i18n translations for external alert integration#3763zstack-robot-2 wants to merge 1 commit into5.5.12from
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml) Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (16)
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough在 Changes
Sequence Diagram(s)sequenceDiagram
rect rgba(200,200,255,0.5)
participant Test as 测试用例
end
rect rgba(200,255,200,0.5)
participant Helper as ApiHelper
end
rect rgba(255,200,200,0.5)
participant Action as SDKAction
end
rect rgba(255,255,200,0.5)
participant Platform as Platform
end
Test->>Helper: 调用 setup/check/removeExternalAlertIntegration(Closure)
Helper->>Action: 实例化对应 Action 并设置 sessionId
Helper->>Helper: 执行 Closure (OWNER_FIRST) 填入参数
alt apipath system property 存在
Helper->>Platform: 若无 apiId 则调用 Platform.uuid() 生成 apiId
Helper->>Helper: 用 ApiPathTracker 跟踪并将路径写入 Test.apiPaths
Helper->>Action: 调用 a.call()
Action-->>Helper: 返回结果
else 无 apipath
Helper->>Action: 直接调用 a.call()
Action-->>Helper: 返回结果
end
Helper-->>Test: 返回或包装并返回结果(errorOut(...))
代码审查工作量估计🎯 3 (Moderate) | ⏱️ ~20 minutes 诗
Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ast-grep (0.42.1)utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.javaComment |
9deef0e to
9c1c60c
Compare
|
Comment from ye.zou: Code ReviewLGTM ✅ 没看到会阻塞合入的问题。 纯数据/生成代码 MR:10 个 i18n JSON 文件各加 2 条 error code(10030/10031),SDK Action/Result 类为标准生成模板, 结论: APPROVE ✅ |
…rnal alert integration Add error code ORG_ZSTACK_ZWATCH_ALARM_10030 (invalid URL) with 10-language i18n translations for the external alert integration API interceptor URL validation. Resolves: ZSTAC-84319 Change-Id: I61657078726f6168766d79626c64727865736d63
9c1c60c to
1c09305
Compare
Add error codes ORG_ZSTACK_ZWATCH_ALARM_10030 (invalid URL) and
ORG_ZSTACK_ZWATCH_ALARM_10031 (endpoint not found) with 10-language
i18n translations for the external alert integration API interceptor.
Resolves: ZCF-991
Change-Id: I61657078726f6168766d79626c64727865736d63
sync from gitlab !9632