fix(bg3): write modsettings backup as utf-8 and avoid home-relative path errors in log cleanup#213
Closed
Illustar0 wants to merge 2 commits intoModOrganizer2:masterfrom
Closed
fix(bg3): write modsettings backup as utf-8 and avoid home-relative path errors in log cleanup#213Illustar0 wants to merge 2 commits intoModOrganizer2:masterfrom
Illustar0 wants to merge 2 commits intoModOrganizer2:masterfrom
Conversation
Contributor
|
@Illustar0 its helpful to tag someone when you have a pr ready. Someone else made a PR today for this and tagged me and I saw it. Only saw this after doing a look around the repo while I was here. Unless you arent satisfied with #218, then I think we can close this, yeah? And of course you can always tag |
Author
|
Thanks for the heads-up! Closing this one. |
Member
|
My bad, I completely missed this already existing PR before making mine. It's a simple fix though, so no big deal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 2 errors: