Skip to content

[Baldur's Gate 3]: Fix UnicodeEncodeError and ValueError #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Holt59 merged 3 commits into from
Apr 20, 2026
Merged

[Baldur's Gate 3]: Fix UnicodeEncodeError and ValueError #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a9fb70
[Baldur's Gate 3]: Fix UnicodeEncodeError when writing to mod settings
JonathanFeenstra Apr 19, 2026
3586bcd
[Baldur's Gate 3]: Fix ValueError due to assumption that MO2 is insta…
JonathanFeenstra Apr 19, 2026
539af2e
Format with black
JonathanFeenstra Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion games/baldursgate3/bg3_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,8 @@ def retrieve_mod_metadata_in_new_thread(mod: mobase.IModInterface):
if mod.name() in metadata
)
+ self._mod_settings_xml_end
)
),
encoding="utf-8",
)
qInfo(
f"backing up generated file {self.modsettings_path} to {self.modsettings_backup}, "
Expand Down
14 changes: 4 additions & 10 deletions games/game_baldursgate3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,7 @@ def _on_finished_run(self, exec_path: str, exit_code: int):
moved: dict[str, str] = {}
for path in self.utils.overwrite_path.rglob("*.log"):
try:
moved[str(path.relative_to(Path.home()))] = str(
(self.utils.log_dir / path.name).relative_to(Path.home())
)
moved[str(path)] = str((self.utils.log_dir / path.name))
path.replace(self.utils.log_dir / path.name)
except PermissionError as e:
qDebug(str(e))
Expand All @@ -201,9 +199,7 @@ def _on_finished_run(self, exec_path: str, exit_code: int):
if path.name == "log.txt":
dest = self.utils.log_dir / f"{path.parent.name}-{path.name}"
try:
moved[str(path.relative_to(Path.home()))] = str(
dest.relative_to(Path.home())
)
moved[str(path)] = str(dest)
path.replace(dest)
except PermissionError as e:
qDebug(str(e))
Expand All @@ -230,10 +226,8 @@ def _on_finished_run(self, exec_path: str, exit_code: int):
for folder in sorted(list(fdir.walk(top_down=False)))[:-1]:
try:
folder[0].rmdir()
removed.add(folder[0].relative_to(Path.home()))
removed.add(folder[0])
except OSError:
pass
if cat is not None and cat.isDebugEnabled() and len(removed) > 0:
qDebug(
f"cleaned empty dirs from {fdir.relative_to(Path.home())} {removed}"
)
qDebug(f"cleaned empty dirs from {fdir} {removed}")
4 changes: 1 addition & 3 deletions games/game_divinityoriginalsin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ class DivinityOriginalSinGame(BasicGame):
def init(self, organizer: mobase.IOrganizer):
super().init(organizer)
self._register_feature(
BasicGameSaveGameInfo(
lambda s: s.with_suffix(".png") # Not confirmed
)
BasicGameSaveGameInfo(lambda s: s.with_suffix(".png")) # Not confirmed
)
return True
Loading