fix: switch to Ollama OpenAI-compatible endpoint to resolve tool call validation errors#4
Open
SusieGlitter wants to merge 2 commits intoOpenDataBox:mainfrom
Open
fix: switch to Ollama OpenAI-compatible endpoint to resolve tool call validation errors#4SusieGlitter wants to merge 2 commits intoOpenDataBox:mainfrom
SusieGlitter wants to merge 2 commits intoOpenDataBox:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes Ollama integration fails with tool calls: "role" field missing in Message validation #2
Reproduction Process & Results
I access ollama-0.21.0 on linux server with SSH Port Forwarding while running opencook windows PC, so I can use ollama as model provider with
localhost:11434using
opencook_config.yamlwith config:running opencook in powershell:
and result is after entering the command,
ollama serveshow that no request is sent and no step is shown in opencook cliRefactored ollama_client.py: Switched from the native Ollama library/endpoint to the OpenAI-compatible /v1/chat/completions endpoint.
Improved Message Formatting: By using the OpenAI protocol, messages (including tool roles and tool_outputs) are now automatically formatted correctly according to standard schemas.
doing the same in
2. Reproduction Process & Results, and opencook runs as expected