SubDyn: JSON output file with local x_e axis for circular beams#3310
Merged
andrew-platt merged 2 commits intoOpenFAST:rc-5.0.1from Apr 21, 2026
Merged
Conversation
andrew-platt
approved these changes
Apr 21, 2026
Collaborator
andrew-platt
left a comment
andrew-platt
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Collaborator
|
Adding this to 5.0.1 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
The proposed code modifies the JSON output file from SubDyn. Now, the local x_e local axis for circular beams is also written down in the output file (similar to what we do with the rectangular beams using SideA_dir). This allows to visualize the local coordinate system in viz3Danim (see for reference: ebranlard/viz3Danim#9).
With this modification, the user can orientate the local x_e and y_e axes for circular beams using the spin angle (
MSpin) in SubDyn. Till now, we were computing the default x_e and y_e axes in circular beams within viz3Danim without accounting for the spin angle because we didn't have visibility about it. Now, this information is available for viz3Danim and it can be parsed.Related issue, if one exists
ebranlard/viz3Danim#10
Impacted areas of the software
JSON output file from SubDyn.