Open
Conversation
The setup.py could be removed at this point
Question to claude opus: are `setup.py` files generally being replaced by `pyproject.toml` files in newer python projects? Claude replies: Yes. pyproject.toml is the modern standard (PEP 517/518/621) and is recommended for new projects. Key points: - **setuptools now fully supports pyproject.toml** — no setup.py needed - **pip** has supported pyproject.toml since v10 (2018), and it's mature now - **setup.py is still supported** but considered legacy; many projects keep it for backward compatibility or complex build logic - **setup.cfg** (the intermediate step) is also being phased out in favor of pyproject.toml Since you now have both files, you can safely **delete setup.py** — your pyproject.toml handles everything including: - Package discovery (`[tool.setuptools.packages.find]`) - Version from file (`[tool.setuptools.dynamic]`) - Entry points (`[project.scripts]`) - Dependencies The only reasons to keep setup.py are: 1. Supporting very old pip versions (pre-2018) 2. Complex programmatic build logic that can't be expressed declaratively
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup.py could be removed at this point