Skip to content

UI new schema#179

Open
Dvermetten wants to merge 11 commits intopr-convert-problems.yamlfrom
UI_new_schema
Open

UI new schema#179
Dvermetten wants to merge 11 commits intopr-convert-problems.yamlfrom
UI_new_schema

Conversation

@Dvermetten
Copy link
Copy Markdown
Contributor

No description provided.

Dvermetten and others added 10 commits April 21, 2026 11:56
* adding merge script (untested)

* making tests not fail

* Apply suggestions from code review

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Change example problem format to YAML

Updated example problem format from JSON to YAML.

* requested changes

* follow new workflow

* tested script now

* remove from PR

* remove unnecessary changes here

* undoing changes

* removing additional changes

* undoing changes

* remove file again

* finishing merge

* Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* new_data None

* imports

* removing no changes

* add typing

* change to manual mode

* updated for new workflow

* Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* some additional review updates

* check format fixes

* do not write if failing

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Adds an LLM generated generator for the problems defined in the old
problem.yaml to generate a new style problem.yaml. For future fixes, it is
probably best to update examples/problem.py, regenerate the yaml and then merge
it with the old yaml by replacing entries based on id. That way additional
entries added later are not clobbbered.
@Dvermetten Dvermetten requested a review from kvdblom April 22, 2026 15:00
@olafmersmann olafmersmann force-pushed the pr-convert-problems.yaml branch 3 times, most recently from fff80f0 to a3059ed Compare April 22, 2026 21:26
Copy link
Copy Markdown
Collaborator

@kvdblom kvdblom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would update the title for the visible columns toggle Visible Columns to Toggle Visible Columns. It seemed non-obvious to me what the 'Show' would actually reveal.

Otherwise this looks like it is good to go.

@kvdblom
Copy link
Copy Markdown
Collaborator

kvdblom commented Apr 23, 2026

I would update the title for the visible columns toggle Visible Columns to Toggle Visible Columns. It seemed non-obvious to me what the 'Show' would actually reveal.

Otherwise this looks like it is good to go.

Toggle naming fixed.

@olafmersmann olafmersmann force-pushed the pr-convert-problems.yaml branch from a3059ed to 9a9655f Compare April 23, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants